fix(tempo): include withdrawal fallback nonce - #385
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Superseded by #384 so Viem main can consume the fix from its Ox 0.x dependency line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the existing
WithdrawalSenderTag.fromAPI from #348 to derive nonce-bound Tempo Zone withdrawal sender tags.Motivation
Zone user withdrawals hash
sender || transactionHash || fallbackNonce. OmittingfallbackNoncereturns a tag that cannot locate the parent-chainWithdrawalProcessedevent.The implementation follows the production Zone source at revision
689ffbe:Withdrawal::sender_tagdefines the hash preimage, andWithdrawalRequestedexposesfallbackNonce.Changes
fallbackNoncein the existingWithdrawalSenderTag.frominput.uint64for user withdrawals.Testing
pnpm test --project tempo-unit --bail=1 src/tempo/WithdrawalSenderTag.test.tspnpm check:typespnpm check0xf1acbae45cd689281144042331e3379cf631a8d2db83057ccf38754a0b0108f2.