Skip to content

refactor: convert blockNumber to bigint - #4

Merged
jxom merged 1 commit into
mainfrom
jxom/block-number-bigint
Dec 13, 2022
Merged

refactor: convert blockNumber to bigint#4
jxom merged 1 commit into
mainfrom
jxom/block-number-bigint

Conversation

@jxom

@jxom jxom commented Dec 13, 2022

Copy link
Copy Markdown
Member

Refactoring blockNumber to be a bigint instead of a number. Could be possible for an L2 to overflow.

@changeset-bot

changeset-bot Bot commented Dec 13, 2022

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7b2b785

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Dec 13, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
viem-benchmark ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 5:11AM (UTC)
viem-playground ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 5:11AM (UTC)

@codecov

codecov Bot commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4 (7b2b785) into main (998dfba) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2186      2188    +2     
  Branches       208       208           
=========================================
+ Hits          2186      2188    +2     
Impacted Files Coverage Δ
packages/core/src/actions/account/fetchBalance.ts 100.00% <100.00%> (ø)
packages/core/src/actions/block/fetchBlock.ts 100.00% <100.00%> (ø)
...ackages/core/src/actions/block/fetchBlockNumber.ts 100.00% <100.00%> (ø)
...s/core/src/actions/transaction/fetchTransaction.ts 100.00% <100.00%> (ø)
packages/core/test/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jxom

jxom commented Dec 13, 2022

Copy link
Copy Markdown
Member Author

lol sick @codecov

@jxom
jxom merged commit fe30d27 into main Dec 13, 2022
@jxom
jxom deleted the jxom/block-number-bigint branch December 13, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant