Skip to content

refactor(tempo): use Ox WithdrawalSenderTag - #4943

Merged
jxom merged 4 commits into
wevm:v3from
struong:struong/tempo-withdrawal-sender-tag-v3
Aug 2, 2026
Merged

refactor(tempo): use Ox WithdrawalSenderTag#4943
jxom merged 4 commits into
wevm:v3from
struong:struong/tempo-withdrawal-sender-tag-v3

Conversation

@struong

@struong struong commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

Replaces Viem’s private withdrawal sender-tag helper with the public WithdrawalSenderTag utility from Ox. Targets Viem v3, which already uses the Ox 1.x line.

Motivation

The sender tag is a protocol-level Tempo Zones value and should have one public implementation shared by Viem, Privy, and other consumers. Viem main/2.55.x remains on Ox 0.14.x and requires the broader Ox 1.x migration before it can consume this API.

Changes

  • Updated Ox to the preview from feat(tempo): add WithdrawalSenderTag ox#348: https://pkg.pr.new/ox@f126804.
  • Imported WithdrawalSenderTag from ox/tempo in requestWithdrawalSync.
  • Removed Viem’s duplicate private helper.
  • Updated the withdrawal test to compare against the public Ox utility.

Testing

  • pnpm test src/tempo/actions/zone/requestWithdrawal.test.ts --bail=1
  • pnpm check
  • pnpm check:types
  • pnpm build
  • pnpm test:build

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

@struong is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c752f7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@4943

commit: c38a0c8

@struong
struong marked this pull request as ready for review July 31, 2026 20:22
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
viem Error Error Jul 31, 2026 10:00pm

Request Review

@jxom
jxom merged commit 403530d into wevm:v3 Aug 2, 2026
24 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants