refactor(tempo): use Ox WithdrawalSenderTag - #4943
Merged
Merged
Conversation
|
@struong is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
commit: |
struong
marked this pull request as ready for review
July 31, 2026 20:22
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Viem’s private withdrawal sender-tag helper with the public
WithdrawalSenderTagutility from Ox. Targets Viem v3, which already uses the Ox 1.x line.Motivation
The sender tag is a protocol-level Tempo Zones value and should have one public implementation shared by Viem, Privy, and other consumers. Viem main/2.55.x remains on Ox 0.14.x and requires the broader Ox 1.x migration before it can consume this API.
Changes
https://pkg.pr.new/ox@f126804.WithdrawalSenderTagfromox/tempoinrequestWithdrawalSync.Testing
pnpm test src/tempo/actions/zone/requestWithdrawal.test.ts --bail=1pnpm checkpnpm check:typespnpm buildpnpm test:build