Skip to content

fix(tempo): respect token metadata batching config - #4956

Merged
tmm merged 5 commits into
mainfrom
struong/fix-zone-token-metadata
Aug 4, 2026
Merged

fix(tempo): respect token metadata batching config#4956
tmm merged 5 commits into
mainfrom
struong/fix-zone-token-metadata

Conversation

@struong

@struong struong commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

Updates Tempo token metadata reads to honor explicit client multicall configuration while preserving deployless Multicall3 as the action's default.

Motivation

Zone clients cannot execute deployless contract-creation eth_call requests. Explicitly disabling client multicall should allow token.getMetadata to use ordinary contract reads without changing the default behavior for existing Tempo clients.

Changes

  • Preserved deployless metadata multicall when the client does not specify a multicall setting.
  • Used concurrent readContract calls when the client explicitly configures multicall behavior.
  • Preserved pathUSD fields, declared-token overrides, logo URI fallback, and deterministic required-field errors.
  • Added focused Tempo and Zone coverage plus a patch changeset.

Testing

  • pnpm test src/tempo/actions/token.test.ts --run — 76 passed, 1 existing skip.
  • pnpm check:types
  • pnpm build:types
  • Attempted VITE_TEMPO_ZONES=true pnpm test src/tempo/actions/zone.test.ts --run; the local Zone container exited before tests because the configured dev key did not own ZoneFactory.

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5e25f5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
viem Ready Ready Preview Aug 4, 2026 5:17pm

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Aug 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@4956

commit: 5e25f5e

@struong
struong enabled auto-merge (squash) August 4, 2026 17:22
@tmm
tmm disabled auto-merge August 4, 2026 17:34
@tmm
tmm merged commit 3304d2e into main Aug 4, 2026
100 of 114 checks passed
@tmm
tmm deleted the struong/fix-zone-token-metadata branch August 4, 2026 17:35
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants