Fix isHash accepting odd-length hex strings - #5042
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c5a192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Wagalidoom is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
isHash accepting odd-length hex strings
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isHashreturnstruefor hex strings of 65 characters, one short of a valid32-byte hash. The most common way to produce one is truncating a real hash by a
single character, so the false positive lands exactly where validation matters.
Cause
isHashisisHex(hash) && size(hash) === 32.isHexin strict mode accepts anodd number of nibbles, and
sizerounds up:Math.ceil(63 / 2) === 32. So 63nibbles report as 32 bytes and pass the check.
Impact
Validation passes client-side and the value fails later, further down the stack.
A node rejects it with
-32602 invalid params, so the error surfaces from insidea query or a receipt wait rather than at the input boundary. For comparison,
ethers rejects the same string:
isHexString(value, 32)returnsfalseandgetBytesthrows.Note
The same pattern (
size(value) === Nused as a validator on untrusted input) appears at several other call sites.