Skip to content

feat: polish websocket rpc implementation - #8

Merged
jxom merged 1 commit into
mainfrom
jxom/rpc-refactor
Dec 20, 2022
Merged

feat: polish websocket rpc implementation#8
jxom merged 1 commit into
mainfrom
jxom/rpc-refactor

Conversation

@jxom

@jxom jxom commented Dec 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@changeset-bot

changeset-bot Bot commented Dec 20, 2022

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 298a896

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Dec 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
viem-benchmark ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 10:00PM (UTC)
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 10:00PM (UTC)
viem-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 10:00PM (UTC)

@codecov

codecov Bot commented Dec 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8 (298a896) into main (dfdd6ed) will increase coverage by 0.00%.
The diff coverage is 99.59%.

@@           Coverage Diff            @@
##             main       #8    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files          61       61            
  Lines        2569     2706   +137     
  Branches      299      309    +10     
========================================
+ Hits         2568     2705   +137     
  Misses          1        1            
Impacted Files Coverage Δ
packages/core/src/utils/rpc.ts 99.74% <99.58%> (-0.26%) ⬇️
packages/core/src/utils/BaseError.ts 100.00% <100.00%> (ø)
packages/core/test/utils.ts 100.00% <100.00%> (ø)
...src/actions/transaction/fetchTransactionReceipt.ts 100.00% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jxom
jxom merged commit e705ba8 into main Dec 20, 2022
@jxom
jxom deleted the jxom/rpc-refactor branch December 20, 2022 22:26
jxom added a commit that referenced this pull request Nov 5, 2023
* Fix: cip64 regressions (#6)

* fix: refactor cip64 to be more robust

* fix: types

* fix: signTransaction tests

* refactor: PR feedback

* chore: add changeset

* test: add celo/utils test coverage (#8)

* CELO utils test coverage

* test: generate new address for each test

---------

Co-authored-by: Nicolas Brugneaux <nicolas.brugneaux@gmail.com>

* chore: update src/chains/celo/utils.ts

Co-authored-by: jxom  <jakemoxey@gmail.com>

* Update yellow-eggs-compare.md

---------

Co-authored-by: Leszek Stachowski <leszkostachowski@gmail.com>
Co-authored-by: jxom <jakemoxey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant