Run CI on the Node versions the lockfile supports - #13
Open
robrigo wants to merge 1 commit into
Open
Conversation
The lockfile pins smob@1.6.1, which declares engines node >=20, so yarn install --frozen-lockfile fails on the 14, 16, and 18 runners and every run since the lockfile update has been red at the install step. Node 14 through 18 are also past end of life. This moves the matrix to 20, 22, and 24 and the two actions to their current majors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every CI run since the yarn.lock update has failed at the install step: the lockfile pins
smob@1.6.1, whoseenginesfield requires Node 20 or newer, andyarn install --frozen-lockfilerefuses it on the 14, 16, and 18 runners. Those Node lines are also past end of life. This moves the matrix to 20, 22, and 24 and the two actions to their current majors. No source change;make checkandmake testare unchanged.