Meta: lazy-load the spec's own images and iframes - #12867
Open
zcorpan wants to merge 3 commits into
Open
Conversation
Add `loading="lazy"` to every `<img>` and `<iframe>` in the spec, except the WHATWG logo in the header, to improve page loading performance. Six images had no dimensions to lay out with while unloaded, and so would have shifted layout on scroll. They now carry `width` and `height` attributes: the intrinsic sizes for `sample-bdi.png`, `sample-not-bdi.png`, `select-country-1.png`, and `select-country-2.png`, and sizes matching the `viewBox` aspect ratio for `asyncdefer.svg` and `custom-element-reactions.svg`, whose rendered size continues to come from their `style` attributes. Part of #12782.
Member
Author
|
https://web.archive.org/web/20251211020906/https://www.tpgi.com/short-note-on-coding-alt-text/ I'll look into codifying this in https://github.com/whatwg/html/blob/main/.github/CONTRIBUTING.md#source-formatting and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
loading="lazy"to every<img>and<iframe>in the spec, except the WHATWG logo in the header, to improve page loading performance.Six images had no dimensions to lay out with while unloaded, and so would have shifted layout on scroll. They now carry
widthandheightattributes: the intrinsic sizes forsample-bdi.png,sample-not-bdi.png,select-country-1.png, andselect-country-2.png, and sizes matching theviewBoxaspect ratio forasyncdefer.svgandcustom-element-reactions.svg, whose rendered size continues to come from theirstyleattributes.Part of #12782.