UpdateAll with includes - #1360
Merged
Merged
Conversation
Added the functionality to reference included tables in the updateAll function. Also added a testcase for it.
Fixed the error for Postgre and SQL server Databases as both of these have different syntax for Update from MySQL. Take the following example which shows the same task being performed in all three databases with different syntaxes: --MySQL Update posts LEFT OUTER JOIN comments ON posts.id = Comments.postid SET averagerating = 5 WHERE Comments.postid = 1 AND posts.deletedat IS NULL -- PostgreSQL Update posts SET averagerating = 5 FROM Comments WHERE posts.id = Comments.postid AND Comments.postid = 1 AND posts.deletedat IS NULL --SQL Server Update posts SET averagerating = 5 FROM posts LEFT OUTER JOIN comments ON posts.id = Comments.postid WHERE Comments.postid = 1 AND posts.deletedat IS NULL
Collaborator
|
@zainforbjs the H2 tests for Lucee 5 and Lucee 6 are failing. Can you take a look at this. |
Contributor
Author
@bpamiri We are good to go now. |
bpamiri
approved these changes
Dec 5, 2023
This was referenced May 12, 2026
Merged
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the functionality to reference included tables in the updateAll function. Also added a testcase for it.