fix(view): drop /wheels/* top nav in favor of debug footer#2419
Merged
Conversation
The top navigation in _header.cfm duplicated links already provided by the debug bar emitted at onrequestend (System Info / Routes / API / Guides / Migrator / Packages / Plugins). Drop the nav include to eliminate the duplicate surface. Public.cfc handlers <cfinclude> their views directly without going through renderView, so request.wheels.showDebugInformation never flipped on /wheels/info, /wheels/routes, etc. — the bar wouldn't have appeared even after dropping the top nav. Opt into the bar from both _header.cfm and _header_simple.cfm so any view using either layout self-arms the debug footer. Extends the pattern from #2406 (welcome + error pages) to the rest of the dev-tools admin pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_header.cfm— duplicates links already in the debug bar emitted atonrequestend(System Info / Routes / API / Guides / Migrator / Packages / Plugins)._header.cfmand_header_simple.cfmintorequest.wheels.showDebugInformation = trueso the debug bar emits on/wheels/*admin pages and the welcome page. Necessary becausePublic.cfchandlers<cfinclude>their views directly without going throughrenderView(), which is what normally flips that flag.Extends the pattern from #2406 (welcome + error pages) to the rest of the dev-tools admin pages — every view that uses either header layout now has the debug footer as its only chrome.
Why
/wheels/info,/wheels/routes,/wheels/api, etc. were rendering with two parallel navigation surfaces: the top nav from_header.cfmAND the debug bar at the bottom. Both linked to the same destinations. Removing the top nav consolidates dev-tools navigation into a single surface and matches the look established for the welcome page.Test plan
/(welcome page) renders with debug bar at bottom/wheels/inforenders without top nav, with debug bar at bottomdebug.cfm)/wheels/infoboth return HTTP 200; framework dev rig boots cleanly