fix(view): replace broken database icon on migrator error placeholder

[bpamiri]

Summary

• Closes Broken icon displayed on migrator page when a database error occurs #2425. The "Database Error" placeholder on /wheels/migrator used <i class="database icon">, but the framework inlines Semantic UI's CSS via <cfinclude> and never ships the themes/default/assets/fonts/ webfont, so the icon rendered as a blank square (see screenshot in the issue).
• Replaced with an inline FontAwesome database SVG — the same path already used in the "No migration files found!" placeholder on the same view — tinted #f38ba8 (the page's red error token) so the error state still reads visually.

Before / After

• Before: broken/blank box above "Database Error".
• After: red database icon, matching the visual style of the other inline-SVG icons on the page.

Test plan

• wheels start --port=8080, visit /wheels/migrator with a misconfigured datasource → red database SVG renders above the "Database Error" heading; #message# text still shows.
• Confirm /wheels/migrator still renders normally when the datasource is reachable (no regression — only the error branch was touched).

Follow-up

The same <i class="...icon"> pattern is broken in four other dev-tools views (templating.cfm, packages.cfm, packagelist.cfm, docs/guides.cfm). Tracked as a separate sweep — out of scope for this fix.

🤖 Generated with Claude Code

[wheels-bot]

Wheels Bot — Reviewer A

TL;DR: This is a clean, surgical visual fix. The broken Semantic UI icon font reference is correctly replaced with an inline SVG that exactly mirrors the existing grey database icon on the same view, re-tinted red to match the error state. Verdict: comment (no blocking issues — one pre-existing note flagged below).

---

Correctness

The approach is sound. The replacement SVG at line 299:

• Uses the identical path data and dimensions (height="70" width="50" viewBox="0 0 448 512") as the grey database icon at line 290 ("No migration files found").
• Applies fill="##f38ba8" — the same error-red token already used throughout the file — matching the intended error-state visual.
• The ## prefix is the correct CFML escape sequence for a literal # inside a .cfm template; the rendered SVG will receive the valid hex color #f38ba8.

The structural placement is also consistent: the SVG closes on its own line followed immediately by <br>, then the label text on the next line — identical to the grey variant at lines 290–291.

Security

Note (pre-existing, not introduced by this PR):

// vendor/wheels/public/views/migrator.cfm, line 301
#message#</small>

The message variable is rendered without EncodeForHTML(). In practice this is low-risk — /wheels/migrator is a developer admin tool that should not be accessible in production, and the message content originates from the database layer (system-generated), not from user input. This is not a blocker for this fix but would be worth addressing as part of any broader hardening pass on the dev-tools views.

Commits

fix(view): replace broken database icon font with inline SVG on migrator error
— type fix and scope view are both in the commitlint allowlist; subject is 67 characters, sentence-case. Clean.

Docs

No doc updates needed. The follow-up scope (four other broken icon references in templating.cfm, packages.cfm, packagelist.cfm, docs/guides.cfm) is correctly deferred and noted in the PR body.

[wheels-bot]

Wheels Bot — Reviewer B (round 1)

A's review is accurate throughout. The factual claims all check out against the actual file, there is no sycophancy, and no missed issues of substance on a change this narrow. I am aligning with A's assessment and recommending approval.

Sycophancy

None detected. A explicitly chose a non-approving "comment" verdict and cited concrete evidence for every claim rather than issuing a bare LGTM.

False positives

None detected.

• Dimensions match: Verified. Lines 290 and 299 both use height="70" width="50" viewBox="0 0 448 512" with identical path data; only the fill differs (##6c7086 vs ##f38ba8).
• CFML ## escape: Verified correct. ##f38ba8 in a .cfm template emits #f38ba8 to the browser.
• Structural consistency: Verified. Both the grey and red variants follow the same </svg><br> inline pattern at the end of their SVG line, followed by label text on the next line.
• #message# origin: Verified at line 13 (message = err.message; in a catch (database err) block). Content is system-generated from the CFML database driver, not user input. A's "low risk, pre-existing" characterisation is accurate.

Missed issues

None detected. The diff is a single-line substitution in a dev-admin view; no cross-engine compatibility concerns apply to inline SVG in a .cfm template, and the fix itself introduces nothing new worth flagging.

Verdict alignment

A's "comment" verdict is consistent with the findings. For a bot review a non-approving "comment" is a conservative but defensible stance; the formal approval gate is reserved for humans. The position is coherent: no blocking issues, one pre-existing note documented for visibility, no requests to change the PR itself.

Convergence

A and I are aligned. The fix is correct, all claims are accurate, and there is nothing to change. The PR is clean for this SHA; a human reviewer can approve and merge.