Test emitted ranges #263
Merged
Test emitted ranges #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases where the lexer will see a number with a suffix, like this:
42r
...But will determine that the apparent suffix is not actually part of the
number, and will back up so as not to consume it. In such cases, the emitted
range should not include this bogus suffix.
Owner
|
Can we just test those in the parser tests? Lexer tests aren't even close to exhaustive anyway. |
Collaborator
Author
Oh, I see... you have those things like I think the value of checking in the lexer tests as well is shown by the bug which I discovered this way. But it's up to you. |
Owner
|
Hrm, this is actually not possible to test in |
Owner
|
Well, I guess it doesn't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on optimization of
Range#line, I looked at what tests we have for ranges emitted by the lexer and was surprised to discover that the test suite hardly checks anything at all as re: correctness of the lexed ranges.Perhaps unsurprisingly, when I tightened the test suite up to check the begin and end of each emitted range, it led me to discover a (relatively minor) bug.
@whitequark, see if you like the way the ranges are tested here or if you would prefer something else.