Skip to content

* parser/current: update 2.4 branch to 2.4.1.#342

Closed
tagliala wants to merge 1 commit intowhitequark:masterfrom
tagliala:update-24-branch
Closed

* parser/current: update 2.4 branch to 2.4.1.#342
tagliala wants to merge 1 commit intowhitequark:masterfrom
tagliala:update-24-branch

Conversation

@tagliala
Copy link
Copy Markdown

No description provided.

@whitequark
Copy link
Copy Markdown
Owner

This must wait until #336 is fixed.

@whitequark
Copy link
Copy Markdown
Owner

whitequark commented Mar 26, 2017

Also, #337. #337 goes into 2.5, so it's not holding up this.

@tagliala
Copy link
Copy Markdown
Author

tagliala commented Mar 26, 2017

Looks like it was fixed on 2.4.1:

ruby/ruby@v2_4_0...v2_4_1

ruby/ruby@c093d46

2.4.1 :005 >   foo :bar, {
2.4.1 :006 >       a: proc do
2.4.1 :007 >         end,
2.4.1 :008 >       b: proc do
2.4.1 :009 >         end
2.4.1 :010?>   }
 => [:bar, {:a=>#<Proc:0x007fa2a58dbc20@(irb):6>, :b=>#<Proc:0x007fa2a58dbbf8@(irb):8>}] 
2.4.0 :001 > def foo a, h
2.4.0 :002?>     [a, h]
2.4.0 :003?>   end
 => :foo 
2.4.0 :004 > 
2.4.0 :005 >   foo :bar, {
2.4.0 :006 >       a: proc do
2.4.0 :007 >         end,
2.4.0 :008 >       b: proc do
2.4.0 :009 >         end
2.4.0 :010?>   }
SyntaxError: (irb):8: syntax error, unexpected keyword_do_block, expecting '}'
  b: proc do
            ^

@whitequark
Copy link
Copy Markdown
Owner

whitequark commented Mar 26, 2017

Exactly. And it wasn't fixed in parser yet, so I can't release 2.4.1 yet.

@SaschaM-Dev
Copy link
Copy Markdown

any updates on this?

@whitequark
Copy link
Copy Markdown
Owner

No.

@whitequark whitequark mentioned this pull request May 6, 2017
@whitequark whitequark closed this May 26, 2017
@sPaCeMoNk3yIam
Copy link
Copy Markdown

Why is this closed? I still get the error.

@whitequark
Copy link
Copy Markdown
Owner

@sPaCeMoNk3yIam Dupe of #346.

@bbatsov bbatsov mentioned this pull request Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants