Add pagination tests (step 10)#7
Merged
Merged
Conversation
Expand dealer edge-case coverage to match listings: stops_on_none_next_offset, max_pages=0, and None filter for both paginate_dealers and iter_dealers. Tighten iter_dealers_two_pages to assert offset advancement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_pagination.pythat were tracked in the FIXES.md backlog:test_paginate_dealers_stops_on_none_next_offsettest_paginate_dealers_max_pages_zero_yields_nothingtest_paginate_dealers_none_filter_uses_defaultstest_iter_dealers_max_pages_zero_yields_nothingtest_iter_dealers_none_filter_uses_defaultstest_iter_dealers_two_pagesto assert offset advancement (0 → 2), matching the symmetry of the listings tests._pagination.py— the implementation already handled all cases correctly.Test plan
pytest tests/test_pagination.py— 22 passed (was 17)pytest— 192 passedruff check src/ tests/— cleanmypy src/— clean🤖 Generated with Claude Code