worker: gate rule publishing on a dedicated SITE_RULES_PUBLISH_KEY secret - #13
Merged
Conversation
Publishing now checks `:key` against a standalone SITE_RULES_PUBLISH_KEY secret instead of requiring a publish:true entry in API_KEYS. API_KEYS is unreadable and must be re-supplied whole to edit, so adding a publisher entry there risked wiping existing customer keys. A dedicated secret is set independently: openssl rand -hex 24 | npx wrangler secret put SITE_RULES_PUBLISH_KEY 503s if the secret is unset; 403s on mismatch. No customer key can publish. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate rule-publishing on a dedicated secret (not API_KEYS)
Follow-up to #12. The
publish: true-on-API_KEYSapproach required editing theAPI_KEYSsecret to add a publisher entry — but Cloudflare secrets can't be read back, so editing means re-supplying the whole value, and if you don't have the current customer keys saved, that blind overwrite would wipe them.This switches
POST /v1/site-rules/:keyto check the:keyagainst a standaloneSITE_RULES_PUBLISH_KEYsecret, set independently ofAPI_KEYS:API_KEYS.wrangler.toml+bench/publish-rules.sh.After merge: redeploy, then
openssl rand -hex 24 | npx wrangler secret put SITE_RULES_PUBLISH_KEY.🤖 Generated with Claude Code