fix(ci): revert numpy 2.5.1 bump that broke the Python matrix#375
Merged
Conversation
This reverts commit 16079f2.
numpy >=2.5 dropped support for Python < 3.12, but ci.yml still runs the Python matrix on 3.9/3.10/3.11. A dependabot bump to numpy 2.5.1 (#367) broke every Python CI row ("No matching distribution"); ignore numpy minor/major bumps in the hash-locked .github/requirements tooling so it can't recur.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled CI on
mainfailed: Python 3.9/3.10/3.11/3.13 on all OSes could not installnumpy==2.5.1("No matching distribution") — numpy 2.5 dropped Python < 3.12, but the CI matrix still tests those. Root cause: dependabot ci-pip bump #367 pinned numpy 2.0.2→2.5.1 in bothci-dev-py3.txtandci-dev-py39.txt.Fix
ignorefor numpy minor/major in the/.github/requirementsgroup so the same 2.5.x bump can't re-break the matrix next cycle.Note: the separate
Fuzz (smoke)failure on that run is an unrelated nightly rustc ICE (compiler crash building tokio on nightly), not caused by any dependency change.