The asobi_lua merge (#339) snapshotted asobi_lua at its commit b01c5dc
(asobi_lua#124). Verified by byte-comparing every shared module against
asobi@733cec4:src/lua/.
Four commits landed in asobi_lua after that point and are not here:
Spot checks: registration appears 20 times in asobi_lua/src/asobi_lua_config.erl
and 0 times in asobi/src/lua/asobi_lua_config.erl. asobi/test/ has
asobi_storage_SUITE.erl (the Erlang storage path) but no equivalent of
asobi_lua_storage_SUITE.erl (the Lua game.storage.* path, which is what let
#296 through).
The four need porting on top of the post-merge refactors here (#340, #341, #342,
#343 all touched src/lua/), so they are not clean cherry-picks.
Why this is blocking
widgrensit/asobi_lua#135 retires asobi_lua to a Docker alias: it deletes the
duplicated source and rebuilds ghcr.io/widgrensit/asobi_lua from asobi alone.
Merging it before these are ported would drop all four out of the published image.
Port these, cut a release, then bump the asobi tag in asobi_lua/rebar.config
to that release and merge the retirement PR.
There is also in-flight work in asobi_lua on a fix/storage-update-badarg-296
branch touching src/lua/asobi_lua_api.erl and test/asobi_lua_api_tests.erl
that should be reopened here.
The
asobi_luamerge (#339) snapshottedasobi_luaat its commitb01c5dc(asobi_lua#124). Verified by byte-comparing every shared module against
asobi@733cec4:src/lua/.Four commits landed in
asobi_luaafter that point and are not here:4b4bf8econfig.luaglobal3354e5egame.storage.*write path (asobi_lua_storage_SUITE)af391ffbase_stateandzone.spawnoverride keys1bc28begame.broadcastevent names for immediate script feedbackSpot checks:
registrationappears 20 times inasobi_lua/src/asobi_lua_config.erland 0 times in
asobi/src/lua/asobi_lua_config.erl.asobi/test/hasasobi_storage_SUITE.erl(the Erlang storage path) but no equivalent ofasobi_lua_storage_SUITE.erl(the Luagame.storage.*path, which is what let#296 through).
The four need porting on top of the post-merge refactors here (#340, #341, #342,
#343 all touched
src/lua/), so they are not clean cherry-picks.Why this is blocking
widgrensit/asobi_lua#135 retires
asobi_luato a Docker alias: it deletes theduplicated source and rebuilds
ghcr.io/widgrensit/asobi_luafromasobialone.Merging it before these are ported would drop all four out of the published image.
Port these, cut a release, then bump the
asobitag inasobi_lua/rebar.configto that release and merge the retirement PR.
There is also in-flight work in
asobi_luaon afix/storage-update-badarg-296branch touching
src/lua/asobi_lua_api.erlandtest/asobi_lua_api_tests.erlthat should be reopened here.