feat: dispatch asobi_lua pin bump on release - #315
Merged
Merged
Conversation
Downstream asobi_lua pins asobi by git ref and refreshes it on a nightly schedule, so a fix released here can wait up to a day before reaching the published image (asobi_lua#103). Fire a repository_dispatch at asobi_lua the moment a release is tagged instead. The reusable erlang-ci release workflow takes no extra steps and reports success even when no bump was due, so the dispatch runs as a follow-on job gated on a tag actually pointing at HEAD. Closes #276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream
asobi_luapinsasobiby git ref and only refreshes that pin on its nightly schedule, so a fix released here can sit unpublished for up to a day (widgrensit/asobi_lua#103, mitigations 2 and 3 shipped in asobi_lua#115). This is the missing option 1: push the news instead of making asobi_lua poll for it.What changed
scripts/dispatch-asobi-lua-pin-bump.shfiresrepository_dispatch(event_type=asobi-released,client_payload[tag]) atwidgrensit/asobi_lua.release.ymlruns it as a follow-on job after the release job.scripts/test/dispatch-asobi-lua-pin-bump-test.shcovers the branches withghstubbed on PATH;scripts.ymlruns the script tests in CI (ci.yml delegates wholesale to erlang-ci, which only knows rebar3).Why a job and not a step
The release is a reusable workflow (
Taure/erlang-ci), so no step can be inserted into it, and it exports no output saying whether it actually tagged - it reports success on every merge to main, including the ones git-cliff decides need no bump. The script therefore gates on a release tag actually pointing at HEAD, so ordinary merges dispatch nothing.Follow-ups outside this repo
ASOBI_LUA_DISPATCH_TOKEN(PAT or app token with write access towidgrensit/asobi_lua) has to be added; the defaultGITHUB_TOKENcannot dispatch across repositories. Until it exists the job logs a::warning::and passes, so releases never go red on a missing secret.asobi_lua'sbump-asobi-pin.ymlneedsrepository_dispatch: types: [asobi-released]alongside itsscheduleandworkflow_dispatchtriggers. Until then the dispatch is accepted and ignored, and the nightly remains the only path.Closes #276