chore(deps): nova from Hex, and no git deps left - #409
Merged
Conversation
nova 0.15.3 is on Hex and is the same commit the git ref pinned (a334a6d), so the temporary override can go. The floor is `~> 0.15.3` rather than `~> 0.15` on purpose. 0.15.1 is the release that crashes the connection process when a websocket controller replies with a list of frames, and `~> 0.15` would let it resolve again. The comment says so, because the obvious tidy-up later is to widen it. This was the last git dependency. asobi's lock is now 21 Hex packages and nothing else, which is what Hex requires of a package it accepts, so this is what unblocks publishing asobi itself. Verified on a clean _build: eunit 1661 tests, ct 341 tests against Postgres 17, plus xref, dialyzer and fmt. cowboy resolves to 2.18.0. Closes #347
🟡 Code Coverage — 75.6%6860 of 9070 lines covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nova 0.15.3 is on Hex and is the same commit the git ref pinned (
a334a6d), so the temporary override goes away.Why the floor is
~> 0.15.3Not
~> 0.15. 0.15.1 is the release that crashes the connection process when a websocket controller replies with a list of frames (nova_basic_handler:handle_ws/2conses the payload onto the command list as one element, so the whole list reachescow_ws:frame/2as a single frame).~> 0.15would let that resolve again. The comment inrebar.configsays so, because widening it is the obvious tidy-up for someone later.This unblocks publishing asobi
nova was the last git dependency. Hex will not accept a package that has one, which is why asobi has been stuck at 0.35.4 on Hex while git is at v0.72.2. The lock is now 21 Hex packages and nothing else.
Verification
Clean
_build:fmt --checkclean{git,entries inrebar.lockCloses #347