fix: build Docker image as part of release workflow - #45
Merged
Conversation
GITHUB_TOKEN events don't trigger other workflows, so the separate docker.yml never fired on release. Move Docker build into release.yml as a job that runs after the release is created.
Taure
added a commit
that referenced
this pull request
Aug 6, 2026
ghcr.io/widgrensit/asobi:0 points at a 2026-04-06 build - pre-Lua-merge, pre-console - while :latest is current. The tag was published by a workflow deleted in #45 and nothing has republished it since, so the floating major, which is what a careful operator pins, silently serves April code that boots and looks fine. This workflow emitted {{version}} and {{major}}.{{minor}} but never {{major}}, so it could never take that tag over. It does now. A major pin is still weak on a 0.x line where minors are not compatible; guides/self-hosting.md steers readers to a minor or a digest. This is about the tag not being actively wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.ymlintorelease.ymlas aneeds: releasejobdocker.yml(no longer needed)GITHUB_TOKENevents (tags, releases) don't trigger other workflows. The only way to chain release → Docker is within the same workflow.Test plan