Skip to content

Insert link tool no longer suggests articles based on selected text#5220

Merged
mazevedofs merged 3 commits intowikimedia:mainfrom
KelCodesStuff:bug-fix-T387322
Mar 31, 2025
Merged

Insert link tool no longer suggests articles based on selected text#5220
mazevedofs merged 3 commits intowikimedia:mainfrom
KelCodesStuff:bug-fix-T387322

Conversation

@KelCodesStuff
Copy link
Contributor

This commit addresses a bug where the search bar in InsertLinkViewController was not being pre-populated with the highlighted text when the link button was pressed.

  • Modified viewDidAppear to check for a link.page value.
  • If a link.page value exists, the search bar is pre-populated with it.

Phabricator:
T387322

Notes

Test Steps

  1. Select an article
  2. Click the edit source button
  3. Highlight a word in the article to open the edit tools
  4. Click the link button
  5. The search view will open with the selected text in the search bar and search results displayed

Screenshots/Videos

Screen.Recording.2025-03-07.at.6.03.57.PM.mov

…ontroller

- Modified viewDidAppear to check for a link.page value.
- If a link.page value exists, the search bar is pre-populated with it.
@KelCodesStuff KelCodesStuff changed the title Pre-populate search bar with highlighted text in InsertLinkViewController Insert link tool no longer suggests articles based on selected text Mar 22, 2025
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mazevedofs mazevedofs merged commit b4c606d into wikimedia:main Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants