feat: Add support for the DISCARD section in linker scripts - #1978
Merged
Conversation
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
vishruth-thimmaiah
force-pushed
the
discard
branch
from
May 25, 2026 02:44
bed75a2 to
7d9b24c
Compare
davidlattimore
changed the title
| //#DiffIgnore:segment.LOAD.RX.alignment | ||
| //#DiffIgnore:segment.LOAD.RWX.alignment | ||
| //#DoesNotContain:DISCARD | ||
| //#DoesNotContain:.text |
Member
There was a problem hiding this comment.
I wonder if we want to test whether we emit the symbol foo or not. From a quick experiment, it looks like wild and lld don't emit foo, while GNU ld weirdly does. So if we went that route ("NoSym:foo"), then we'd likely need to disable GNU ld and enable lld for the test.
Member
Author
There was a problem hiding this comment.
Making foo static stops ld from emitting it in .dynsym, so we should be able to keep ld as well.
Member
There was a problem hiding this comment.
A static that isn't referenced could be eliminated by the compiler, so might make the test pass even without /DISCARD/ support
Member
Author
There was a problem hiding this comment.
I see, I've updated the test to only use lld.
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
Signed-off-by: vishruth-thimmaiah <vishruththimmaiah@gmail.com>
davidlattimore
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support discarding sections that are marked as discardable with the
/DISCARD/command in linker scripts.Closes: #1829