[WFLY-20952] Added integration tests to the JTS quickstart#1179
Conversation
kstekovi
left a comment
There was a problem hiding this comment.
Review of the integration tests added to the JTS quickstart.
kstekovi
left a comment
There was a problem hiding this comment.
Apologies for the late comments — these should have been caught in the first review round but I ran out of time yesterday.
|
Nitpick on |
kstekovi
left a comment
There was a problem hiding this comment.
All review comments from both rounds have been addressed. The integration tests are well structured, the timing issues are handled correctly with polling helpers, the management client dependency has been cleanly replaced with a REST endpoint, and the README now documents the expected warnings for both deployment and integration test phases. LGTM!
emmartins
left a comment
There was a problem hiding this comment.
Sorry, we need one more round.
|
Thanks @jmfinelli |
emmartins
left a comment
There was a problem hiding this comment.
Sorry missed something
|
@jmfinelli this is the way, thank you |
Addresses WFLY-20952