WFLY-21592 Legacy Node.getSocketAddress() always returns null#19745
Merged
rhusar merged 1 commit intowildfly:mainfrom Mar 13, 2026
Merged
WFLY-21592 Legacy Node.getSocketAddress() always returns null#19745rhusar merged 1 commit intowildfly:mainfrom
rhusar merged 1 commit intowildfly:mainfrom
Conversation
Member
|
/retest All failed with 'Cannot find commit'... |
rhusar
approved these changes
Mar 13, 2026
Comment on lines
8
to
+14
| import org.infinispan.remoting.transport.Address; | ||
| import org.jgroups.PhysicalAddress; | ||
| import org.wildfly.clustering.jgroups.spi.PhysicalAddressCache; | ||
| import org.wildfly.clustering.server.infinispan.CacheContainerGroupMember; | ||
|
|
||
| import java.net.InetSocketAddress; | ||
| import java.util.Optional; |
Member
There was a problem hiding this comment.
Import out of order but lets not waste more CI minutes.
Member
|
CI failures known and unrelated |
Member
|
Thanks @pferraro |
jbliznak
reviewed
Mar 15, 2026
|
|
||
| @Override | ||
| public void channelDisconnected(JChannel channel) { | ||
| this.caches.remove(channel.getClusterName()); |
Contributor
There was a problem hiding this comment.
(no jira since service is down)
@pferraro after this PR, we now get NPE on this line during shutdown of a server started with standalone-full-ha.xml
22:44:23,005 INFO [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 5) WFLYCLJG0034: Disconnecting 'ee' channel. 'my-host' leaving cluster 'ejb' with view: [my-host(v=16.0.5)|0] (1) [my-host(v=16.0.5)]
22:44:23,007 INFO [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0004: Undertow 2.3.23.Final stopping
22:44:23,050 INFO [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 5) WFLYCLJG0035: Disconnected 'ee' channel. 'my-host' left cluster 'ejb'
22:44:23,051 WARN [org.wildfly.service.Installer$NonBlockingValueService] (ServerService Thread Pool -- 5) java.lang.NullPointerException: Cannot invoke "Object.hashCode()" because "key" is null: java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "Object.hashCode()" because "key" is null
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1807)
at org.jboss.threads@3.9.2//org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads@3.9.2//org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2651)
at org.jboss.threads@3.9.2//org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2630)
at org.jboss.threads@3.9.2//org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1622)
at org.jboss.threads@3.9.2//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1589)
at java.base/java.lang.Thread.run(Thread.java:842)
at org.jboss.threads@3.9.2//org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: java.lang.NullPointerException: Cannot invoke "Object.hashCode()" because "key" is null
at java.base/java.util.concurrent.ConcurrentHashMap.replaceNode(ConcurrentHashMap.java:1111)
at java.base/java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1102)
at org.wildfly.clustering.jgroups.spi@40.0.0.Beta1-SNAPSHOT//org.wildfly.clustering.jgroups.spi.PhysicalAddressCache.channelDisconnected(PhysicalAddressCache.java:38)
at org.jboss.as.clustering.jgroups@40.0.0.Beta1-SNAPSHOT//org.jboss.as.clustering.jgroups.subsystem.AbstractChannelResourceDefinitionRegistrar$5.accept(AbstractChannelResourceDefinitionRegistrar.java:287)
at org.jboss.as.clustering.jgroups@40.0.0.Beta1-SNAPSHOT//org.jboss.as.clustering.jgroups.subsystem.AbstractChannelResourceDefinitionRegistrar$5.accept(AbstractChannelResourceDefinitionRegistrar.java:278)
at java.base/java.util.function.Consumer.lambda$andThen$0(Consumer.java:65)
at java.base/java.util.function.Consumer.lambda$andThen$0(Consumer.java:65)
at org.wildfly.service@32.0.0.Beta4//org.wildfly.service.BlockingLifecycle$2$1.stop(BlockingLifecycle.java:143)
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
... 7 more
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
@jbliznak can you create the jira now please?
Please don't.
Member
There was a problem hiding this comment.
You are right, the fix should be associated with the original Jira.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-21592