Skip to content

pwa.manifest missing

Jump to bottom
github-actions[bot] edited this page Sep 6, 2026 · 2 revisions

pwa.manifest-missing

Rule ID: pwa.manifest-missing Severity: WARN Category: pwa Target Standards: W3C Web App Manifest Section 4 (Linking to a Manifest), HTML Living Standard Section 4.2.4 (The link element), Chromium Progressive Web App Discovery Engine

1. Overview & Core Invariant

Warns when the HTML document

is missing a declaration

Core Invariant:

"The HTML document or root layout must include a '' tag with a non-empty href attribute."

2. Technical Grounding & Engine Realities

For mobile and desktop browsers to locate and parse a web application's manifest file, the root HTML document must link to it via a tag within the

section.

Without this explicit link element, browsers cannot discover the manifest, and consequently will never offer the install banner ('Add to Home Screen') or configure standalone display mode.

Including a valid manifest link in the document head ensures seamless PWA discovery across Chromium, Safari, and Gecko engines.

3. Vulnerability & Risk Taxonomy

Risk Vector Severity Impact
PWA Feature Invisibility HIGH Browsers treat the site as a traditional desktop webpage and never offer PWA installation or offline capabilities.
Missing Homescreen Install Capability MEDIUM Users on mobile devices cannot install the web app to their home screen or application launcher.

4. Non-Compliant Code Patterns (Bad Examples)

TSX (HTML head without a manifest link element):

<head>
  <title>Layanan Surat Desa</title>
  <meta name="viewport" content="width=device-width, initial-scale=1" />
</head>

5. Compliant Implementation Patterns (Good Examples)

TSX (HTML head declaring a manifest link with valid href):

<head>
  <title>Layanan Surat Desa</title>
  <meta name="viewport" content="width=device-width, initial-scale=1" />
  <link rel="manifest" href="/manifest.webmanifest" />
</head>

6. Detection & Verification Pipeline (How The Rule Evaluates Code)

This rule evaluates source code through the standard AST inspection pipeline:

flowchart TD
    Node["AST Node (Astro / TSX element)"] --> Inspect["1. Inspect Element & Attributes"]
    Inspect --> Invariant{"2. Evaluate Rule Invariant"}
    Invariant -- "Compliant" --> Safe["Pass"]
    Invariant -- "Non-Compliant" --> IgnoreCheck{"3. Check charites:ignore directive"}
    IgnoreCheck -- "Ignored" --> Safe
    IgnoreCheck -- "Not Ignored" --> Diag["4. Emit Diagnostic: pwa.manifest-missing"]
Loading

Step-by-Step Evaluation:

  1. AST Traversal: Visits normalized ir.Node structures during AST streaming.
  2. Invariant Check: Compares node attributes against rule invariants.
  3. Directive Suppression Check: Honors inline charites:ignore pwa.manifest-missing directives.
  4. Diagnostic Emission: Emits compiler-grade diagnostic on invariant violation.

7. Verification & Test Harness (How The Test Works: 1-SSOT Tri-Corpus)

This rule is rigorously tested and validated across the canonical 1-SSOT Tri-Corpus in tests/correctness/pwa.manifest-missing/:

flowchart TD
    subgraph GoldenCorpus ["1-SSOT Tri-Corpus Test Matrix for pwa.manifest-missing"]
        subgraph P ["Positive Corpus (tests/correctness/pwa.manifest-missing/positive/)"]
            P1["P1: Obvious Direct Violation"]
            P2["P2: Indirect / Variant Concatenation"]
            P3["P3: Helper / clsx / cn Wrapper"]
            P4["P4: Deeply Nested Elements"]
            P5["P5: Aliased Imports / Re-exports"]
        end
        subgraph N ["Negative Corpus (tests/correctness/pwa.manifest-missing/negative/)"]
            N1["N1: Valid Design Tokens"]
            N2["N2: Explicit charites:ignore Directive"]
            N3["N3: Third-Party / Vendor Components"]
            N4["N4: Clean Semantic HTML"]
            N5["N5: Untokenized Custom Values (Banana Test)"]
        end
        subgraph A ["Adversarial Corpus (tests/correctness/pwa.manifest-missing/adversarial/)"]
            A1["A1: Template Literal Interpolations"]
            A2["A2: Ternary Conditional Expressions"]
            A3["A3: Spread Properties & Dynamic Overrides"]
            A4["A4: Dynamic Object Class Syntax"]
            A5["A5: Shadowed Variable Identifiers"]
            A6["A6: Nested Closures & HOC Wrappers"]
            A7["A7: Obfuscated Classes & Cyclic Tokens"]
        end
    end

    P --> TestRunner["Automated Runner (rule_test.go)"]
    N --> TestRunner
    A --> TestRunner
    TestRunner --> Gates["Quality Gates: Zero Panic, Zero False-Positive, Zero Bypass"]
Loading
  • Positive Fixtures (P1-P5): Verified to trigger diagnostics at exact lines and column spans.
  • Negative Fixtures (N1-N5): Verified to produce zero diagnostics on valid tokens and legitimate exemptions.
  • Adversarial Fixtures (A1-A7): Verified to prevent evasion across dynamic expressions, string interpolations, and cyclic references.

8. How to Suppress (Ignore Directives)

If this pattern is required for an intentional exception, suppress the diagnostic using the canonical Charites Rule ID:

<!-- charites:ignore pwa.manifest-missing intentional exception -->
// charites:ignore pwa.manifest-missing intentional exception

9. Configuration Reference (charites.yaml)

rules:
  pwa.manifest-missing:
    severity: warn # error | warn | info | off

Charites Wiki

Rule Categories

A11y (16 rules)
Browser (12 rules)
Cls (16 rules)
Design (1 rules)
Ergonomy (5 rules)
Inp (16 rules)
Lcp (16 rules)
Mobile (5 rules)
Performance (16 rules)
Pwa (10 rules)
Responsive (18 rules)
Semantic (1 rules)
Theme (32 rules)
Ux (20 rules)

Clone this wiki locally