Conversation
…n coupling decision - Add pytest-timeout (via make deps) with a 120s per-test default so a wedged worker-pool wait fails fast instead of hanging CI (#131). - Register gui and slow markers (--strict-markers): every test under tests/gui/ is auto-marked gui by the conftest, and the Monte Carlo, backtest, and retirement-solver sweep modules are marked slow, so both sets can be deselected locally and sharded in CI (#131). - Record the app-layer/region coupling decision in planning section 4.7: the direct app -> regions.uk imports are accepted for the UK-first shell, and a new boundary guard pins the confinement - the gui shell must keep reaching region data through the app layer (#134). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the two small infra issues deferred from #128.
#131 — pytest-timeout + registered markers
pytest-timeoutadded throughmake deps(lockfile churn isolated to this PR; the cooldown cutoff moved to 2026-07-30 andfilelock/hypothesis/pippicked up in-cooldown upgrades).guiandslowmarkers registered (--strict-markerswas on with no project markers). Every test undertests/gui/is auto-markedguiby a conftest collection hook so new GUI test files cannot forget it; the Monte Carlo, backtest, and retirement-solver sweep modules are markedslowat module level.-m 'not gui'/-m 'not slow'now deselect cleanly (166 and 104 tests respectively), ready for local skips and CI sharding — and for the heavier hypothesis suite planned in Property-based tests over the engine (hypothesis) #132.#134 — app-layer/region coupling decision
glidepath.regions.ukimports are accepted for the UK-first shell. §4.2's isolation promise protects the core (already guard-tested); the app layer is region-shaped presentation plumbing a second region would rework anyway. A region-selection Protocol now would be an abstraction with one implementation and no second customer — revisit when a second region is real.test_gui_shell_never_imports_regions, alongside the existing §4.2 guards): the coupling stays confined to the app layer — the gui shell keeps reaching region data throughglidepath.app, so a future seam has exactly one layer to cut into.Testing
make checkgreen: ruff, ruff format, mypy --strict, 1910 tests at 99.07% coverage, dep-age gate OK.-m guicollects 166,-m slowcollects 104, remainder 1640.Fixes #131
Fixes #134
🤖 Generated with Claude Code