Refactor LCA Euler Tour: cleanup, bazel docs, expand tests#1262
Merged
williamfiset merged 1 commit intomasterfrom Mar 7, 2026
Merged
Refactor LCA Euler Tour: cleanup, bazel docs, expand tests#1262williamfiset merged 1 commit intomasterfrom
williamfiset merged 1 commit intomasterfrom
Conversation
- Replace gradle run instructions with bazel test command in javadoc - Move main method to bottom of class - Move TreeNode class to top for better readability - Replace System.out warning in rootTree with IllegalArgumentException - Replace LinkedList with ArrayList for children and adjacency lists - Rename createFirstTreeFromSlides to createSampleTree - Expand tests from 4 to 12 covering symmetry, root ancestry, parent-child LCA, single/two node trees, linear chains, TreeNode properties, and malformed graph detection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainmethod to bottom,TreeNodeclass to top for better readabilitySystem.out.printlnwarning inrootTreewithIllegalArgumentExceptionfor malformed graphsLinkedListwithArrayListfor children lists and adjacency listsTest plan
bazel testLowestCommonAncestorunchanged and passing🤖 Generated with Claude Code