Skip to content

feat: selectively sync upstream canary fixes - #1

Merged
windinternet merged 18 commits into
canaryfrom
codex/upstream-sync-2026-07-15
Jul 15, 2026
Merged

feat: selectively sync upstream canary fixes#1
windinternet merged 18 commits into
canaryfrom
codex/upstream-sync-2026-07-15

Conversation

@windinternet

@windinternet windinternet commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • Selectively adopt upstream backup-keyring, Compose volume-mode, API-key validation, server-domain, and repository-selector fixes.
  • Preserve Chinese localization while porting UI changes.
  • Record an ours-merge baseline for upstream canary, so the reviewed-and-declined SSO and English-copy commits are not repeatedly surfaced.

Verification

  • Biome check on all changed files.
  • Targeted Dokploy tests: api-key-name, compose volume services, and encryption.
  • Dokploy typecheck.
  • i18n catalog check.
  • Documentation check.

Note: validation ran on Node 22.22.3; the repository declares Node 24.4.0.

Siumauricio and others added 18 commits July 10, 2026 03:16
API key names longer than 32 characters were rejected by better-auth
with a 400 that surfaced as an opaque INTERNAL_SERVER_ERROR (the generic
"Failed to generate API key" toast). Add a shared name schema (min 1,
max 32, matching better-auth's default maximumNameLength) used by both
the tRPC input and the client form, and surface the limit on the Name
field so users see it before submitting.

Fixes Dokploy#4798
feat: export full keyring in backup encryption key file
…-name-length

fix: validate API key name length to prevent opaque 500
The randomize/isolated-deployment volume transform split mount strings
on ':' and kept only the first two segments, so an access mode like
:ro, :z or :Z was silently dropped and read-only mounts became
read-write. Keep the full path+mode remainder when rebuilding the
mount string.

Fixes Dokploy#4818
…x-access-mode

fix(compose): preserve named-volume access mode when adding suffix
The Server Domain form rejected an empty value ('Invalid domain name'),
making domain assignment a one-way operation. The backend already
removes the Traefik router and clears the host when it receives an
empty host, so only the client-side validation blocked removal.

Allow an empty domain to clear it, and skip the https/letsencrypt
requirements when the domain is being removed.

Fixes Dokploy#4821
…ctor

The repository CommandItem used the repo name as its cmdk value and
the check icon compared only names, so two repos with the same name in
different owners/orgs showed the selected checkmark and hover on both
entries. Key the item by owner/name and include the owner in the
selected comparison. GitLab already keyed by URL and is unaffected.

Fixes Dokploy#4793
Updated the PopoverContent components across various provider files to ensure consistent width and padding. Enhanced the display of repository and branch names by adding truncation to prevent overflow in the UI. This change applies to Bitbucket, Gitea, GitHub, and GitLab provider components, as well as their respective compose components.
…ate-names

fix(ui): disambiguate repos with the same name in the repository selector
…r-domain

fix(settings): allow clearing the server domain
The randomize/isolated-deployment volume transform split mount strings
on ':' and kept only the first two segments, so an access mode like
:ro, :z or :Z was silently dropped and read-only mounts became
read-write. Keep the full path+mode remainder when rebuilding the
mount string.

Fixes Dokploy#4818

(cherry picked from commit bc22d05)
@autofix-troubleshooter

Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@windinternet
windinternet merged commit 88b0450 into canary Jul 15, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants