Skip to content

chore(docs): tweaks to the quickshare doc - #7192

Merged
mergify[bot] merged 3 commits into
mainfrom
eladb-patch-6
Oct 7, 2024
Merged

chore(docs): tweaks to the quickshare doc#7192
mergify[bot] merged 3 commits into
mainfrom
eladb-patch-6

Conversation

@eladb

@eladb eladb commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@eladb
eladb requested a review from a team as a code owner October 6, 2024 12:29
@github-actions

github-actions Bot commented Oct 6, 2024

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 6, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 6, 2024
@monadabot

monadabot commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Console preview environment is available at https://wing-console-pr-7192.fly.dev 🚀

Last Updated (UTC) 2024-10-07 23:39

@monadabot

Copy link
Copy Markdown
Contributor

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (1a6ac19) for suspicious changes.
This is typically caused by:

  • Absolute paths
  • Timestamps
  • Random values
  • Flakey tests (relying on one of the above)

@monadabot

Copy link
Copy Markdown
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜🟥⬜🟥⬜⬜⬜
Benchmark Before After Change
version 60ms±0.48 58ms±0.82 -2ms (-3.61%)⬜
hello_world.test.w -t sim 433ms±6.02 431ms±9.17 -2ms (-0.48%)⬜
hello_world.test.w -t tf-aws 1557ms±12.47 1543ms±9.65 -13ms (-0.86%)⬜
jsii_small.test.w -t sim 391ms±7.09 393ms±3.62 +2ms (+0.63%)⬜
jsii_small.test.w -t tf-aws 627ms±7.52 624ms±5.67 -4ms (-0.58%)⬜
jsii_big.test.w -t sim 3063ms±9.71 3042ms±16.27 -22ms (-0.71%)⬜
jsii_big.test.w -t tf-aws 3262ms±29.86 3291ms±16.13 +28ms (+0.87%)⬜
empty.test.w -t sim 374ms±4.11 387ms±4.22 +12ms (+3.26%)🟥
empty.test.w -t tf-aws 610ms±5.21 625ms±5.64 +15ms (+2.5%)⬜
functions_10.test.w -t sim 499ms±20.22 527ms±6.51 +29ms (+5.78%)🟥
functions_10.test.w -t tf-aws 2203ms±18.47 2255ms±19.05 +52ms (+2.35%)⬜
functions_1.test.w -t sim 415ms±4.05 414ms±1.96 -2ms (-0.36%)⬜
functions_1.test.w -t tf-aws 859ms±7.39 860ms±5.78 +2ms (+0.21%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 56ms 59ms 1ms 1ms
hello_world.test.w -t sim 431ms 413ms 453ms 9ms 13ms
hello_world.test.w -t tf-aws 1543ms 1526ms 1563ms 10ms 13ms
jsii_small.test.w -t sim 393ms 384ms 400ms 4ms 5ms
jsii_small.test.w -t tf-aws 624ms 609ms 637ms 6ms 8ms
jsii_big.test.w -t sim 3042ms 3020ms 3098ms 16ms 23ms
jsii_big.test.w -t tf-aws 3291ms 3264ms 3329ms 16ms 23ms
empty.test.w -t sim 387ms 379ms 397ms 4ms 6ms
empty.test.w -t tf-aws 625ms 615ms 644ms 6ms 8ms
functions_10.test.w -t sim 527ms 515ms 540ms 7ms 9ms
functions_10.test.w -t tf-aws 2255ms 2205ms 2284ms 19ms 27ms
functions_1.test.w -t sim 414ms 408ms 418ms 2ms 3ms
functions_1.test.w -t tf-aws 860ms 846ms 874ms 6ms 8ms
Last Updated (UTC) 2024-10-07 23:44

@mergify

mergify Bot commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb-patch-6 is up-to-date with main and the queue is empty.

@mergify
mergify Bot merged commit 71d8506 into main Oct 7, 2024
@mergify
mergify Bot deleted the eladb-patch-6 branch October 7, 2024 23:45
@monadabot

Copy link
Copy Markdown
Contributor

Congrats! 🚀 This was released in Wing 0.85.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants