Skip to content

feat: make public_key the entity id of StoredCredential [WPB-22045]#1653

Merged
SimonThormeyer merged 23 commits intomainfrom
simon/feat/credential-primary-key-WPB-22045
Dec 10, 2025
Merged

feat: make public_key the entity id of StoredCredential [WPB-22045]#1653
SimonThormeyer merged 23 commits intomainfrom
simon/feat/credential-primary-key-WPB-22045

Conversation

@SimonThormeyer
Copy link
Member

@SimonThormeyer SimonThormeyer commented Dec 5, 2025 •
edited
Loading

What's new in this PR

See title

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025 •
edited
Loading

🐰 Bencher Report

Branchsimon/feat/credential-primary-key-WPB-22045
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
Commit add f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		17,330.00 µs
Commit add f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		743.58 µs
Commit add f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		4,180.30 µs
Commit add f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		7,550.60 µs
Commit add f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		11,423.00 µs
Commit add f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		14,234.00 µs
Commit add f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		997,100.00 µs
Commit add f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		725.29 µs
Commit add f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		78,703.00 µs
Commit add f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		215,340.00 µs
Commit add f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		422,420.00 µs
Commit add f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		671,000.00 µs
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		115,000.00 µs
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		22,808.00 µs
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		41,210.00 µs
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		57,080.00 µs
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		81,065.00 µs
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		92,478.00 µs
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
⚠️ NO THRESHOLD		17,129.00 µs
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
⚠️ NO THRESHOLD		115,180.00 µs
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
⚠️ NO THRESHOLD		34,100.00 µs
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
⚠️ NO THRESHOLD		55,573.00 µs
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
⚠️ NO THRESHOLD		74,500.00 µs
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
⚠️ NO THRESHOLD		94,217.00 µs
Commit remove f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		10,719.00 µs
Commit remove f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		573.92 µs
Commit remove f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		2,342.90 µs
Commit remove f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		4,023.00 µs
Commit remove f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		6,247.50 µs
Commit remove f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		8,135.20 µs
Commit remove f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		13,571.00 µs
Commit remove f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		134,520.00 µs
Commit remove f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		110,510.00 µs
Commit remove f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		86,422.00 µs
Commit remove f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		61,975.00 µs
Commit remove f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		38,090.00 µs
Commit update f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		134,560.00 µs
Commit update f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		753.78 µs
Commit update f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		27,842.00 µs
Commit update f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		56,353.00 µs
Commit update f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		82,406.00 µs
Commit update f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		108,520.00 µs
🐰 View full continuous benchmarking report in Bencher

@SimonThormeyer SimonThormeyer force-pushed the simon/feat/credential-primary-key-WPB-22045 branch 7 times, most recently from 132b0d9 to 0cce2e0 Compare December 9, 2025 15:57
@SimonThormeyer SimonThormeyer changed the title Simon/feat/credential primary key wpb 22045 feat: make public_key the entity id of StoredCredential [WPB-22045] Dec 9, 2025
@SimonThormeyer SimonThormeyer marked this pull request as ready for review December 9, 2025 16:03
@SimonThormeyer SimonThormeyer requested a review from a team December 9, 2025 16:03
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/credential-primary-key-WPB-22045 branch 4 times, most recently from e8e7680 to 1c6375a Compare December 10, 2025 12:00
coriolinus
coriolinus approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@SimonThormeyer SimonThormeyer force-pushed the simon/feat/credential-primary-key-WPB-22045 branch 4 times, most recently from 51f3a1f to 566da2d Compare December 10, 2025 14:06
@SimonThormeyer
test: also assert the ciphersuite when deduplicating credentials
287bcca
@SimonThormeyer
feat(keystore/wasm): add mls_credentials_new object store
68e5d04 
...With `public_key` as primary key.
@SimonThormeyer
build: move to our idb fork
c767179 
We're keeping this until the first release after devashishdxt/idb#36 is
resolved.

Also, remove `indexmap` dependency, because we don't need it anymore.
@SimonThormeyer
chore: drop usages of Metabuilder
e55194f 
We don't need it anymore, we have its features on our idb fork now.
@SimonThormeyer
chore: drop metabuilder module
771c6a9
@SimonThormeyer
feat(keystore/wasm): migrate credentials to new object store
d94753d
@SimonThormeyer
fix(keystore/wasm): update migration target version
9e2a99a 
Also move it into a place where the author of a new migration is more
likely to be reminded to update it.
@SimonThormeyer
feat(keystore/generic): update credentials schema
376a595
@SimonThormeyer
chore(keystore/generic): update credential Entity impl to new schema
f585dc7
@SimonThormeyer
chore(keystore/generic): no more StoredCredential deletion by value
547e696
@SimonThormeyer
chore(keystore/wasm): no more StoredCredential deletion by value
a11f0cb
@SimonThormeyer
chore(transaction): no more StoredCredential deletion by value
426c60b
@SimonThormeyer
chore: remove usages of StoredCredential deletion by value
d50fb81
@SimonThormeyer
fix: generate a new signature keypair when creating an E2EI enrollment
432bc67
@SimonThormeyer
chore(wasm): provide credential deletion by value in migrations
4c640b1 
Here it's still useful.
@SimonThormeyer
chore(wasm): don't use old credential deletion API in migrations
bf16c6f
@SimonThormeyer
chore(wasm/keystore): add console_error_panic_hook as dev dependency
34a79f9 
It's very helpful when debugging wasm tests.
@SimonThormeyer
test(keystore/wasm): set up panic hook
491e3e7
@SimonThormeyer
test: mls_signature_keypairs is no longer among object stores
d090333
@SimonThormeyer
chore(wasm/keystore): add helper to open a migration connection/trans…
33e5245 
…action

We cannot use the regular `Database::open()` because this would result
in infinite recursion when used in migrations.
@SimonThormeyer
fix(keystore/wasm): stop using Database::open() in keystore migrations
311236f 
This would result in infinite recursion
@SimonThormeyer
refactor: rename StoredCredential.secret_key to private_key
fc5bca9
@SimonThormeyer
refactor: rename StoredCredential.id to session_id to avoid confu…
62ea1ed 
…sion
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/credential-primary-key-WPB-22045 branch from 566da2d to 62ea1ed Compare December 10, 2025 14:20
@SimonThormeyer SimonThormeyer merged commit 62ea1ed into main Dec 10, 2025
12 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/feat/credential-primary-key-WPB-22045 branch December 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@istankovic istankovic istankovic left review comments

@coriolinus coriolinus coriolinus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonThormeyer @istankovic @coriolinus