feat: remove `identities` module by SimonThormeyer · Pull Request #1756 · wireapp/core-crypto

SimonThormeyer · 2026-01-16T16:08:01Z

What's new in this PR

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2026-01-16T16:19:26Z

Bencher Report

Branch	simon/remove-ciphersuite-from-mls-init-WPB-21629
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!
Without a Threshold, no Alerts will ever be generated.
Latency (nanoseconds (ns))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
Commit add f(group size)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	13,913.00 µs
Commit add f(group size)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	632.79 µs
Commit add f(group size)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	3,401.30 µs
Commit add f(group size)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	6,052.40 µs
Commit add f(group size)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	9,318.60 µs
Commit add f(group size)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	12,546.00 µs
Commit add f(number clients)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	780,090.00 µs
Commit add f(number clients)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	685.71 µs
Commit add f(number clients)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	65,613.00 µs
Commit add f(number clients)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	172,470.00 µs
Commit add f(number clients)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	336,670.00 µs
Commit add f(number clients)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	537,750.00 µs
Commit pending proposals f(group size)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	88,829.00 µs
Commit pending proposals f(group size)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	18,784.00 µs
Commit pending proposals f(group size)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	32,888.00 µs
Commit pending proposals f(group size)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	43,933.00 µs
Commit pending proposals f(group size)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	59,130.00 µs
Commit pending proposals f(group size)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	70,285.00 µs
Commit pending proposals f(pending size)/cs1/mem/1	📈 view plot ⚠️ NO THRESHOLD	13,615.00 µs
Commit pending proposals f(pending size)/cs1/mem/101	📈 view plot ⚠️ NO THRESHOLD	87,591.00 µs
Commit pending proposals f(pending size)/cs1/mem/21	📈 view plot ⚠️ NO THRESHOLD	26,823.00 µs
Commit pending proposals f(pending size)/cs1/mem/41	📈 view plot ⚠️ NO THRESHOLD	43,772.00 µs
Commit pending proposals f(pending size)/cs1/mem/61	📈 view plot ⚠️ NO THRESHOLD	57,858.00 µs
Commit pending proposals f(pending size)/cs1/mem/81	📈 view plot ⚠️ NO THRESHOLD	73,030.00 µs
Commit remove f(group size)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	8,766.10 µs
Commit remove f(group size)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	485.79 µs
Commit remove f(group size)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	1,824.40 µs
Commit remove f(group size)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	3,244.50 µs
Commit remove f(group size)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	4,913.20 µs
Commit remove f(group size)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	6,458.50 µs
Commit remove f(number clients)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	11,301.00 µs
Commit remove f(number clients)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	115,550.00 µs
Commit remove f(number clients)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	94,729.00 µs
Commit remove f(number clients)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	74,030.00 µs
Commit remove f(number clients)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	53,138.00 µs
Commit remove f(number clients)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	32,154.00 µs
Commit update f(group size)/cs1/mem/1002	📈 view plot ⚠️ NO THRESHOLD	115,560.00 µs
Commit update f(group size)/cs1/mem/2	📈 view plot ⚠️ NO THRESHOLD	651.84 µs
Commit update f(group size)/cs1/mem/202	📈 view plot ⚠️ NO THRESHOLD	23,909.00 µs
Commit update f(group size)/cs1/mem/402	📈 view plot ⚠️ NO THRESHOLD	46,945.00 µs
Commit update f(group size)/cs1/mem/602	📈 view plot ⚠️ NO THRESHOLD	70,531.00 µs
Commit update f(group size)/cs1/mem/802	📈 view plot ⚠️ NO THRESHOLD	92,988.00 µs

🐰 View full continuous benchmarking report in Bencher

coriolinus · 2026-01-19T13:46:39Z

WDYT of excluding the public key from the credential ref--it might be large--and instead just storing the Sha256Sum in there instead?

SimonThormeyer · 2026-01-19T15:37:02Z

WDYT of excluding the public key from the credential ref--it might be large--and instead just storing the Sha256Sum in there instead?

Sounds good! Would you mind if we did that as a separate item?

coriolinus · 2026-01-19T15:39:23Z

Sounds good! Would you mind if we did that as a separate item?

That's fine, I was just thinking of it here because it was on my mental queue of things to do once we got rid of the "get most recent commit" functionality, which this PR implements.

coriolinus

This is great! A few nits, but I think this is a real improvement.

Now that the identities module is gone, I'm pretty sure that the door is now open to delete all the 1s delays per added credential, because we don't need them to have unique created_at values anymore. I'm agnostic about whether you want to do that in this PR or in a follow-up though.

coriolinus · 2026-01-20T16:09:37Z

-    /// If no credentials are present in the keystore, then one _must_ be created and added to the
-    /// session before it can be used.


This comment seems relevant still.

Really? Now that mls_init() doesn't do anything with credentials anymore it seems a little off to mention them here.

Removing this function is the first step to unlock removal of the `identities` module which would allow querying for most recently added credentials. `e2ei_rotate()` would just take the most recent x509 credential from the DB and set it for the given conversation. This removes that implicit behavior. To allow that, we're now returning a credential ref from `save_x509_credential()`. Note: we're taking a shortcut here on the FFI layer - we're not anymore returning the `NewCrlDistributionPoints` from `save_x509_credential()`. However, CRL handling is going to be rewored in WPB-19580, so it's not worth bothering too much.

This is, much like the parent commit, just to produce an intermediate state after this PR that enables passing tests without _recent credential_ logic. This method is going to disappear by the latest in WPB-19579.

No more implicit _most recent_ credential logic

This is the only real use case for the `identities` module

`find_credentials()` does a superset of what this function used to do - except relying on the implicit _most recent_ logic.

In the parent commit, we just replaced all instances of `find_most_recent_credential()` with `Conversation.find_current_credential()` to cause the code to compile. This is good enough in some cases, but in others we have to be smarter than that: When updating credentials, we need to ensure that we're signing with the signature key of the leaf node we're inserting, but `find_current_credential()` gives us the old one. This commit takes care of that.

Also, refactor a test that would fail after this removal due to clumsy setup.

The `Identities` struct was blocking us from removing ciphersuite/signature scheme parameters from session initialization.

Also, stop loading credentials during `mls_init()` - this is not needed anymore since we're not using the identities cache anymore.

…Key()`

Also, this adds `setConversationCredential()`, which was previously missing in the wrapper.

…ey()`

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch from 248d04c to 0f07043 Compare January 16, 2026 16:14

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch from 0f07043 to 7475791 Compare January 19, 2026 13:28

coriolinus reviewed Jan 19, 2026

View reviewed changes

Comment thread crypto/src/mls/session/credential.rs Outdated

coriolinus reviewed Jan 19, 2026

View reviewed changes

Comment thread crypto/src/mls/session/credential.rs Outdated

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch from 7475791 to 2d4b6fe Compare January 19, 2026 14:02

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch 5 times, most recently from b7a775a to 4a4d932 Compare January 20, 2026 15:49

SimonThormeyer marked this pull request as ready for review January 20, 2026 15:50

SimonThormeyer requested a review from a team January 20, 2026 15:50

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch from afa8e34 to d62693e Compare January 20, 2026 15:59

coriolinus approved these changes Jan 20, 2026

View reviewed changes

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch 2 times, most recently from d54dcaa to 353d7d5 Compare January 21, 2026 08:01

SimonThormeyer added 10 commits January 21, 2026 09:51

refactor!: e2ei_mls_init_only() returns a CredentialRef

0b9c83b

This is, much like the parent commit, just to produce an intermediate state after this PR that enables passing tests without _recent credential_ logic. This method is going to disappear by the latest in WPB-19579.

feat!: new_external_join_proposal() takes a CredentialRef

2797cac

No more implicit _most recent_ credential logic

feat!: e2ei_is_enabled() doesn't use recent credential logic

124d4e8

feat!: remove all functions finding recent credentials

4da4516

This is the only real use case for the `identities` module

feat!: remove client_public_key()

c0f8dbd

`find_credentials()` does a superset of what this function used to do - except relying on the implicit _most recent_ logic.

chore: fix resulting compile errors

b2fbce7

chore: fix failing tests

5f5e831

refactor: remove ununsed internal method Conversation.own_credential()

2ae751f

SimonThormeyer added 13 commits January 21, 2026 09:51

feat: remove Identities.find_credentials()

bda5fc8

Also, refactor a test that would fail after this removal due to clumsy setup.

refactor: stop using identities module to find credentials by pk

9e67b82

refactor: remove Identities.find_credential_by_public_key()

ff023e5

refactor: remove Identities.push_credential() and its usages

6cf7fb4

refactor: remove Identities.remove_by_mls_credential()

b4ff159

refactor: remove Identities.iter()

1ad40ef

refactor: remove Session.is_e2ei_capable()

ff4ec19

refactor: remove identities module [WPB-21629]

a5de37e

The `Identities` struct was blocking us from removing ciphersuite/signature scheme parameters from session initialization.

feat!: remove ciphersuites parameter from mls_init() [WPB-21629]

528d29d

Also, stop loading credentials during `mls_init()` - this is not needed anymore since we're not using the identities cache anymore.

chore: remove now unused Credential functions

c092cac

chore: kotlin: tests use new mlsInit() and stop using `clientPublic…

f557da8

…Key()`

chore: ts: tests use new mlsInit() and stop using clientPublicKey()

fe0502a

Also, this adds `setConversationCredential()`, which was previously missing in the wrapper.

chore: swift: tests use new mlsInit() and stop using `clientPublicK…

d4ddda1

…ey()`

SimonThormeyer force-pushed the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch from 353d7d5 to d4ddda1 Compare January 21, 2026 08:52

SimonThormeyer merged commit d4ddda1 into main Jan 21, 2026
54 of 55 checks passed

SimonThormeyer deleted the simon/remove-ciphersuite-from-mls-init-WPB-21629 branch January 21, 2026 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove `identities` module#1756

feat: remove `identities` module#1756
SimonThormeyer merged 23 commits intomainfrom
simon/remove-ciphersuite-from-mls-init-WPB-21629

SimonThormeyer commented Jan 16, 2026

Uh oh!

github-actions Bot commented Jan 16, 2026 •

edited

Loading

⚠️ WARNING: No Threshold found!

Uh oh!

Uh oh!

Uh oh!

coriolinus commented Jan 19, 2026

Uh oh!

SimonThormeyer commented Jan 19, 2026

Uh oh!

coriolinus commented Jan 19, 2026

Uh oh!

coriolinus left a comment

Uh oh!

Uh oh!

coriolinus Jan 20, 2026

Uh oh!

SimonThormeyer Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		/// If no credentials are present in the keystore, then one _must_ be created and added to the
		/// session before it can be used.

Conversation

SimonThormeyer commented Jan 16, 2026

What's new in this PR

PR Submission Checklist for internal contributors

Uh oh!

github-actions Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bencher Report

⚠️ WARNING: No Threshold found!

Uh oh!

Uh oh!

Uh oh!

coriolinus commented Jan 19, 2026

Uh oh!

SimonThormeyer commented Jan 19, 2026

Uh oh!

coriolinus commented Jan 19, 2026

Uh oh!

coriolinus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coriolinus Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

SimonThormeyer Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jan 16, 2026 •

edited

Loading

SimonThormeyer Jan 21, 2026 •

edited

Loading