Skip to content
This repository was archived by the owner on Oct 27, 2022. It is now read-only.

Conversation

@tarasmelnychuk
Copy link
Contributor

@tarasmelnychuk tarasmelnychuk commented Jun 10, 2019

Added uid field to Person object for cases where the app needs to store some internal information related to the specific contact.

UID - The unique ID for this record. It’s guaranteed never to change, no matter how much the record changes. If you need to store a reference to a record, use this value. (https://developer.apple.com/documentation/addressbook/kabuidproperty?language=objc)

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ffflorian ffflorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be reflected in the JS API, too.

@tarasmelnychuk
Copy link
Contributor Author

Hi @ffflorian thanks for the review, just added uid reference to ts files with my latest commit

@ffflorian
Copy link
Contributor

@ihappycoder thanks, I'll check with the team.

@marcoconti83
Copy link
Member

Hi all,
Thanks for opening this PR! The code looks OK, but I'm missing a bit of context. Can you please add some context to the description of this PR? Why is this needed? What is UID? Was it tested? How?

@tarasmelnychuk
Copy link
Contributor Author

Hi @marcoconti83, updated PR description. We use this lib in out electron application to list contacts from address book, and users able to pin contacts on top in that list, so we need that uid to store it internally and then identify pinned contacts. Now we installing this lib via npm directly from the fork and it works well

@marcoconti83
Copy link
Member

Thanks @ihappycoder !

@ffflorian ffflorian merged commit a1c7eb3 into wireapp:master Jun 11, 2019
@ffflorian
Copy link
Contributor

Published in 3.3.0, thanks @ihappycoder!

@tarasmelnychuk
Copy link
Contributor Author

Published in 3.3.0, thanks @ihappycoder!

Very nice to hear, thanks all! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants