Skip to content
This repository was archived by the owner on Oct 21, 2024. It is now read-only.

add additional (commented) options to restund.conf template#13

Draft
rohan-wire wants to merge 1 commit intofeature/dtls_certfrom
feature/restund-conf
Draft

add additional (commented) options to restund.conf template#13
rohan-wire wants to merge 1 commit intofeature/dtls_certfrom
feature/restund-conf

Conversation

@rohan-wire
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

/etc/restund.conf did not contain examples of all possible configuration statements. Part of FS-503 which didn't get included.

Solutions

All possible configuration statements now either have a default or are included in a comment out line in /etc/restund.conf

Needs releases with:

  • GitHub link to other pull request

Testing

Can't really test until this is deployed in an environment. Chicken and egg problem.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any sort of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants