fix(dev): handle migration progress and network errors [AR-3013]#1398
Merged
Conversation
Contributor
Codecov Report
@@ Coverage Diff @@
## develop #1398 +/- ##
=============================================
- Coverage 36.54% 36.47% -0.07%
- Complexity 603 604 +1
=============================================
Files 215 216 +1
Lines 7394 7424 +30
Branches 920 924 +4
=============================================
+ Hits 2702 2708 +6
- Misses 4447 4470 +23
- Partials 245 246 +1
Continue to review full report at Codecov.
|
MohamadJaara
approved these changes
Jan 27, 2023
Contributor
|
Build available here. Scroll down to Artifacts! |
Collaborator
|
Build 1 succeeded. The build produced the following APK's: |
Collaborator
|
Build 2 succeeded. The build produced the following APK's: |
Contributor
|
Build available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When there's an error during the migration, the app doesn't do anything and becomes stuck on the migration screen.
Solutions
Implement retry mechanism for network errors and let other errors complete the migration as there is nothing we can do with that, retrying won't have any effect.
Add progress steps to the migration to let user know what is being migrated at a given time.
Testing
How to Test
Install the AR as an update to the scala app and perform the migration.
Attachments (Optional)
migration-progress-error.mp4
This video shows the UI changes - each step is delayed by 3s and there is a network error at the end to show the retry mechanism.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.