Skip to content

fix(dev): handle migration progress and network errors [AR-3013]#1398

Merged
saleniuk merged 2 commits into
developfrom
fix/migration-progress-errors/dev
Jan 27, 2023
Merged

fix(dev): handle migration progress and network errors [AR-3013]#1398
saleniuk merged 2 commits into
developfrom
fix/migration-progress-errors/dev

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented Jan 27, 2023

BugAR-3013 Handle migration progress and network errors


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When there's an error during the migration, the app doesn't do anything and becomes stuck on the migration screen.

Solutions

Implement retry mechanism for network errors and let other errors complete the migration as there is nothing we can do with that, retrying won't have any effect.
Add progress steps to the migration to let user know what is being migrated at a given time.

Testing

How to Test

Install the AR as an update to the scala app and perform the migration.

Attachments (Optional)

migration-progress-error.mp4

This video shows the UI changes - each step is delayed by 3s and there is a network error at the end to show the retry mechanism.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2023

Unit Test Results

  51 files    51 suites   31s ⏱️
347 tests 346 ✔️ 1 💤 0

Results for commit 31363b2.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2023

Codecov Report

Merging #1398 (0e83113) into develop (584f343) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 0e83113 differs from pull request most recent head 31363b2. Consider uploading reports for the commit 31363b2 to get more accurate results

@@              Coverage Diff              @@
##             develop    #1398      +/-   ##
=============================================
- Coverage      36.54%   36.47%   -0.07%     
- Complexity       603      604       +1     
=============================================
  Files            215      216       +1     
  Lines           7394     7424      +30     
  Branches         920      924       +4     
=============================================
+ Hits            2702     2708       +6     
- Misses          4447     4470      +23     
- Partials         245      246       +1     
Impacted Files Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <ø> (ø)
...tlin/com/wire/android/datastore/GlobalDataStore.kt 16.66% <0.00%> (ø)
...kotlin/com/wire/android/datastore/UserDataStore.kt 21.87% <0.00%> (ø)
...om/wire/android/datastore/UserDataStoreProvider.kt 0.00% <ø> (ø)
...n/com/wire/android/feature/AccountSwitchUseCase.kt 0.00% <ø> (ø)
...in/kotlin/com/wire/android/mapper/ContactMapper.kt 0.00% <ø> (ø)
...in/com/wire/android/mapper/MessageContentMapper.kt 38.18% <ø> (ø)
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 72.72% <ø> (ø)
...tlin/com/wire/android/mapper/OtherAccountMapper.kt 87.50% <ø> (ø)
...com/wire/android/mapper/UICallParticipantMapper.kt 92.85% <ø> (ø)
... and 209 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2296dcd...31363b2. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

Build available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Copy Markdown
Collaborator

Build 1 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Copy Markdown
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Copy Markdown
Contributor

Build available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit 12b3f67 into develop Jan 27, 2023
@saleniuk saleniuk deleted the fix/migration-progress-errors/dev branch January 27, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants