fix: fixing unit tests in core and features (WPB-23934)#4632
Merged
sbakhtiarov merged 3 commits intodevelopfrom Mar 12, 2026
Merged
fix: fixing unit tests in core and features (WPB-23934)#4632sbakhtiarov merged 3 commits intodevelopfrom
sbakhtiarov merged 3 commits intodevelopfrom
Conversation
Contributor
|
@sbakhtiarov looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
sbakhtiarov
requested review from
Garzas,
MohamadJaara,
ohassine and
saleniuk
and removed request for
saleniuk
Garzas
approved these changes
Mar 10, 2026
MohamadJaara
approved these changes
Mar 10, 2026
saleniuk
approved these changes
Mar 11, 2026
saleniuk
reviewed
Mar 11, 2026
| description = "Reports code coverage on tests within the Wire Android codebase." | ||
| dependsOn("koverXmlReport") | ||
|
|
||
| val validSubprojects = setOf("core", "features") |
Contributor
There was a problem hiding this comment.
I think CI is not running tests from app module as well
# Conflicts: # app/src/test/kotlin/com/wire/android/ui/WireActivityViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/movetofolder/MoveToFolderViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/publiclink/PublicLinkViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/publiclink/settings/password/PublicLinkPasswordScreenViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/rename/RenameNodeViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/util/FileNameResolverTest.kt # kalium
sbakhtiarov
force-pushed
the
fix/unit-tests-build
branch
3 times, most recently
from
2934cf7 to
0d8b6ce
Compare
sbakhtiarov
force-pushed
the
fix/unit-tests-build
branch
from
0d8b6ce to
3334ce0
Compare
|
sbakhtiarov
added a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23934
https://wearezeta.atlassian.net/browse/WPB-23934
What's new in this PR?
Issues
Solutions