fix: navigating back to conversation list on home [WPB-23983][WPB-23980]#4644
Merged
MohamadJaara merged 2 commits intodevelopfrom Mar 11, 2026
Merged
Conversation
saleniuk
changed the title
ohassine
approved these changes
Mar 11, 2026
Garzas
approved these changes
Mar 11, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
MohamadJaara
approved these changes
Mar 11, 2026
…on-home-not-close-app # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/HomeScreen.kt
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23983
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Previously, when user navigated to another screen from home side menu, like settings or archive, and navigated back using system back button/gesture, then the app navigated back to the initial home screen which is the conversation list.
Now, it closes the whole app.
Causes (Optional)
After updating the compose destinations to v2, the graph used in "home" NavHost was changed to the root one and the home one became a subgraph of it, so popping back to the start screen stopped working properly for "home" NavHost since both graphs have a different start destination.
Solutions
Revert that change so that the "HomeGraph" becomes an separate one, as it should be, because it's used only for the "home" navigation (to replace the screen on "home" screen depending on current side menu selection).
Testing
How to Test
STR:
you should be navigated back to conversation list, the app should not close
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.