Skip to content

fix(drive): Sorting drop down missing a divider line (WPB-24101)#4696

Merged
ohassine merged 4 commits intodevelopfrom
Sorting-drop-down-missing-a-divider-line
Apr 8, 2026
Merged

fix(drive): Sorting drop down missing a divider line (WPB-24101)#4696
ohassine merged 4 commits intodevelopfrom
Sorting-drop-down-missing-a-divider-line

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Apr 8, 2026

https://wearezeta.atlassian.net/browse/WPB-24101


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sorting drop down missing a divider line

Causes (Optional)

wrong used colors

Solutions

use right colors

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix (drive): Sorting drop down missing a divider line (WPB-24101) fix(drive): Sorting drop down missing a divider line (WPB-24101) Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.78%. Comparing base (e7fb0ee) to head (eacb993).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4696   +/-   ##
========================================
  Coverage    49.78%   49.78%           
========================================
  Files          600      600           
  Lines        20581    20581           
  Branches      3282     3282           
========================================
  Hits         10247    10247           
  Misses        9365     9365           
  Partials       969      969           
Files with missing lines Coverage Δ
...id/feature/cells/ui/search/sort/SortRowWithMenu.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fb0ee...eacb993. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

@ohassine ohassine enabled auto-merge April 8, 2026 16:50
@ohassine ohassine added this pull request to the merge queue Apr 8, 2026
Merged via the queue into develop with commit 76948f5 Apr 8, 2026
16 of 18 checks passed
@ohassine ohassine deleted the Sorting-drop-down-missing-a-divider-line branch April 8, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants