Skip to content

test: harden shared Android UI test (WPB-24675)#4718

Merged
yamilmedina merged 7 commits intodevelopfrom
wpb-24675-harden-shared-android-ui-tests
Apr 14, 2026
Merged

test: harden shared Android UI test (WPB-24675)#4718
yamilmedina merged 7 commits intodevelopfrom
wpb-24675-harden-shared-android-ui-tests

Conversation

@emmaoke-w
Copy link
Copy Markdown
Contributor

@emmaoke-w emmaoke-w commented Apr 10, 2026

https://wearezeta.atlassian.net/browse/WPB-24675


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Hardened flaky UI interactions with SystemClock-based polling/retry across shared flows, including notification/consent dialogs, menu/settings navigation, and modal visibility/disappearance checks.
  • Added reusable wait helpers in UiWaitUtils:
  • waitUntilVisible
  • waitUntilToastIsDisplayed
  • iSeeSystemMessage
  • assertToastDisplayed
  • Strengthened element stabilization timing in shared wait logic to reduce stale/unstable UI interactions.
  • Updated test-service helpers for more reliable conversation/message handling, including: strict personal MLS send entrypoint
  • Improved shared page-object reliability in registration, settings, conversation list, and personal-account lifecycle related flows.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Harden flaky shared Android UI test interactions across common flows used by critical tests.
Improve test-service reliability for conversation and message handling in personal MLS and related helper flows.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w requested a review from yamilmedina April 10, 2026 14:56
@emmaoke-w emmaoke-w marked this pull request as ready for review April 10, 2026 14:58
@emmaoke-w emmaoke-w requested a review from CinnamonNinja April 13, 2026 12:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.91%. Comparing base (87c7ba0) to head (3600793).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4718   +/-   ##
========================================
  Coverage    49.91%   49.91%           
========================================
  Files          602      602           
  Lines        20650    20650           
  Branches      3291     3291           
========================================
  Hits         10307    10307           
  Misses        9377     9377           
  Partials       966      966           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c7ba0...3600793. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmaoke-w emmaoke-w enabled auto-merge April 13, 2026 14:21
@emmaoke-w emmaoke-w disabled auto-merge April 13, 2026 15:02
@emmaoke-w emmaoke-w enabled auto-merge April 13, 2026 15:02
@emmaoke-w emmaoke-w disabled auto-merge April 13, 2026 15:03
@emmaoke-w emmaoke-w marked this pull request as draft April 13, 2026 15:03
@emmaoke-w emmaoke-w marked this pull request as ready for review April 13, 2026 15:03
@emmaoke-w emmaoke-w changed the title test: harden shared Android UI tests (WPB-24675) test: harden shared Android UI test (WPB-24675) Apr 13, 2026
@emmaoke-w emmaoke-w enabled auto-merge April 13, 2026 15:04
@emmaoke-w emmaoke-w added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@emmaoke-w emmaoke-w enabled auto-merge April 14, 2026 10:12
@emmaoke-w emmaoke-w added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@yamilmedina yamilmedina enabled auto-merge April 14, 2026 17:27
@sonarqubecloud
Copy link
Copy Markdown

@yamilmedina yamilmedina added this pull request to the merge queue Apr 14, 2026
Merged via the queue into develop with commit 1410d93 Apr 14, 2026
17 checks passed
@yamilmedina yamilmedina deleted the wpb-24675-harden-shared-android-ui-tests branch April 14, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants