Skip to content

fix(drive): Correct default sort orders (WPB-24104)#4722

Merged
ohassine merged 15 commits into
developfrom
Correct-default-sort-orders
Apr 28, 2026
Merged

fix(drive): Correct default sort orders (WPB-24104)#4722
ohassine merged 15 commits into
developfrom
Correct-default-sort-orders

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Apr 10, 2026

https://wearezeta.atlassian.net/browse/WPB-24104


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

  • Set FoldersFirst as default sorting in Shared Drive screen and search
  • Make FoldersFirst option not visible in DropDownMenu in shared drive search
  • Set NewestFirst as default sorting in Drive screen and search
  • Avoid loading data when navigating from Drive or Shared drive to Search

Shared Drive

Before After
screen-20260410-183053-1775838639930.mp4
Screen_recording_20260410_182648.mp4

Drive

Before After
screen-20260410-182944-1775838572829.mp4
screen-20260410-182944-1775838572829.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix (drive): Correct default sort orders (WPB-24104) fix(drive): Correct default sort orders (WPB-24104) Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 45.05495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.81%. Comparing base (49a2ae0) to head (1e7b46b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...d/feature/cells/ui/search/SearchScreenViewModel.kt 20.51% 31 Missing ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 70.96% 3 Missing and 6 partials ⚠️
...id/feature/cells/ui/search/sort/SortRowWithMenu.kt 0.00% 4 Missing ⚠️
...id/feature/cells/ui/search/sort/SortingCriteria.kt 71.42% 4 Missing ⚠️
...roid/feature/cells/ui/search/sort/SortingMapper.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4722   +/-   ##
========================================
  Coverage    50.81%   50.81%           
========================================
  Files          603      603           
  Lines        20811    20844   +33     
  Branches      3350     3358    +8     
========================================
+ Hits         10575    10592   +17     
- Misses        9238     9252   +14     
- Partials       998     1000    +2     
Files with missing lines Coverage Δ
...e/android/feature/cells/ui/search/SearchUiState.kt 29.41% <100.00%> (ø)
...roid/feature/cells/ui/search/sort/SortingMapper.kt 20.00% <0.00%> (+20.00%) ⬆️
...id/feature/cells/ui/search/sort/SortRowWithMenu.kt 0.00% <0.00%> (ø)
...id/feature/cells/ui/search/sort/SortingCriteria.kt 71.87% <71.42%> (+7.58%) ⬆️
...com/wire/android/feature/cells/ui/CellViewModel.kt 50.84% <70.96%> (+0.66%) ⬆️
...d/feature/cells/ui/search/SearchScreenViewModel.kt 45.18% <20.51%> (-2.44%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a2ae0...1e7b46b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine requested a review from saleniuk April 24, 2026 09:02
Comment thread features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt Outdated
Comment thread core/navigation/src/main/kotlin/com/wire/android/navigation/WireNavigator.kt Outdated
@ohassine ohassine requested a review from saleniuk April 24, 2026 10:28
@sonarqubecloud
Copy link
Copy Markdown

@ohassine ohassine added this pull request to the merge queue Apr 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026
@ohassine ohassine added this pull request to the merge queue Apr 28, 2026
Merged via the queue into develop with commit 431b2cf Apr 28, 2026
17 checks passed
@ohassine ohassine deleted the Correct-default-sort-orders branch April 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants