Skip to content

feat: Add pagination support to the conversation filter (WPB-23986)#4731

Merged
ohassine merged 8 commits into
developfrom
paginated-conversations
Apr 24, 2026
Merged

feat: Add pagination support to the conversation filter (WPB-23986)#4731
ohassine merged 8 commits into
developfrom
paginated-conversations

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Apr 15, 2026

https://wearezeta.atlassian.net/browse/WPB-23986


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We load all cell conversations at once in conversation filter

Solutions

Add pagination support to load conversations from db when scrolling

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…tions

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/calling/ongoing/OngoingCallViewModel.kt
#	kalium
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.81%. Comparing base (6d4afc8) to head (8c68cf7).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...d/feature/cells/ui/search/SearchScreenViewModel.kt 40.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4731      +/-   ##
===========================================
+ Coverage    50.78%   50.81%   +0.03%     
===========================================
  Files          603      603              
  Lines        20823    20811      -12     
  Branches      3351     3350       -1     
===========================================
+ Hits         10574    10575       +1     
+ Misses        9249     9238      -11     
+ Partials      1000      998       -2     
Files with missing lines Coverage Δ
...e/android/feature/cells/ui/search/SearchUiState.kt 29.41% <100.00%> (+2.94%) ⬆️
...sheet/conversation/ConversationFilterSheetState.kt 100.00% <100.00%> (+6.66%) ⬆️
...d/feature/cells/ui/search/SearchScreenViewModel.kt 47.61% <40.00%> (+5.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4afc8...8c68cf7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine requested a review from sbakhtiarov April 21, 2026 11:13
@ohassine ohassine enabled auto-merge April 24, 2026 11:19
@sonarqubecloud
Copy link
Copy Markdown

@ohassine ohassine added this pull request to the merge queue Apr 24, 2026
Merged via the queue into develop with commit e03051d Apr 24, 2026
16 checks passed
@ohassine ohassine deleted the paginated-conversations branch April 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants