fix: handle proteus bots when apps are disabled [WPB-24956]#4747
Merged
MohamadJaara merged 5 commits intodevelopfrom Apr 23, 2026
Merged
fix: handle proteus bots when apps are disabled [WPB-24956]#4747MohamadJaara merged 5 commits intodevelopfrom
MohamadJaara merged 5 commits intodevelopfrom
Conversation
9a3eee3 to
d201700
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4747 +/- ##
===========================================
+ Coverage 50.67% 50.73% +0.05%
===========================================
Files 603 603
Lines 21482 21518 +36
Branches 3332 3344 +12
===========================================
+ Hits 10887 10917 +30
- Misses 9609 9614 +5
- Partials 986 987 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
alexandreferris
approved these changes
Apr 22, 2026
yamilmedina
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-24956
What's new in this PR?
Issues
Causes (Optional)
The UI reused the same boolean for Apps wording, conversation-level service access, and App-vs-Bot routing. Mixed-protocol fallback also did not distinguish MLS conversations from Proteus bot fallback.
Solutions
BotServiceId.MIXED(PROTEUS)as Bots-enabled for Proteus conversations and Apps-disabled for MLS conversations.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Ran targeted unit tests for conversation details, apps access, app/bot search, add-members routing, and service details. Also ran static analysis.
Notes (Optional)
Verified that unrelated local files were not included in this commit.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.