Skip to content

fix: handle proteus bots when apps are disabled [WPB-24956]#4747

Merged
MohamadJaara merged 5 commits intodevelopfrom
codex/fix-proteus-bots-apps-routing
Apr 23, 2026
Merged

fix: handle proteus bots when apps are disabled [WPB-24956]#4747
MohamadJaara merged 5 commits intodevelopfrom
codex/fix-proteus-bots-apps-routing

Conversation

@MohamadJaara
Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara commented Apr 22, 2026

https://wearezeta.atlassian.net/browse/WPB-24956

What's new in this PR?

Issues

  • Proteus conversations in mixed MLS-default teams showed the new Apps UI when Apps were disabled.
  • Bots could be toggled on but still appear disabled after the conversation updated.
  • Adding a legacy bot opened the new App details route and failed to load bot data.
  • MLS conversations showed app results even when Apps were disabled for the team.

Causes (Optional)

The UI reused the same boolean for Apps wording, conversation-level service access, and App-vs-Bot routing. Mixed-protocol fallback also did not distinguish MLS conversations from Proteus bot fallback.

Solutions

  • Split new Apps UI mode from conversation-level bot/app access.
  • Route Proteus fallback additions through BotServiceId.
  • Treat MIXED(PROTEUS) as Bots-enabled for Proteus conversations and Apps-disabled for MLS conversations.
  • Update Kalium apps config fallback through the linked submodule PR.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Ran targeted unit tests for conversation details, apps access, app/bot search, add-members routing, and service details. Also ran static analysis.

Notes (Optional)

Verified that unrelated local files were not included in this commit.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara force-pushed the codex/fix-proteus-bots-apps-routing branch from 9a3eee3 to d201700 Compare April 22, 2026 16:43
@MohamadJaara MohamadJaara changed the title fix: handle proteus bots when apps are disabled fix: handle proteus bots when apps are disabled [WPB-24956] Apr 22, 2026
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.73%. Comparing base (f6976d5) to head (c26b2ee).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...s/participants/GroupConversationParticipantList.kt 0.00% 3 Missing ⚠️
...tions/details/GroupConversationDetailsViewModel.kt 90.00% 1 Missing and 1 partial ⚠️
...ails/updateappsaccess/UpdateAppsAccessViewModel.kt 81.81% 1 Missing and 1 partial ⚠️
...e/conversations/search/apps/SearchAppsViewModel.kt 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4747      +/-   ##
===========================================
+ Coverage    50.67%   50.73%   +0.05%     
===========================================
  Files          603      603              
  Lines        21482    21518      +36     
  Branches      3332     3344      +12     
===========================================
+ Hits         10887    10917      +30     
- Misses        9609     9614       +5     
- Partials       986      987       +1     
Files with missing lines Coverage Δ
...s/details/options/GroupConversationOptionsState.kt 97.14% <100.00%> (+0.08%) ⬆️
...details/updateappsaccess/UpdateAppsAccessParams.kt 75.00% <100.00%> (+8.33%) ⬆️
.../src/main/kotlin/com/wire/android/util/AppsUtil.kt 90.90% <100.00%> (+0.90%) ⬆️
...e/conversations/search/apps/SearchAppsViewModel.kt 97.95% <90.00%> (-2.05%) ⬇️
...tions/details/GroupConversationDetailsViewModel.kt 89.28% <90.00%> (+0.57%) ⬆️
...ails/updateappsaccess/UpdateAppsAccessViewModel.kt 90.38% <81.81%> (-1.29%) ⬇️
...s/participants/GroupConversationParticipantList.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6976d5...c26b2ee. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@MohamadJaara MohamadJaara merged commit d6aaa82 into develop Apr 23, 2026
18 checks passed
@MohamadJaara MohamadJaara deleted the codex/fix-proteus-bots-apps-routing branch April 23, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants