Skip to content

test: centralize created-user teardown[WPB-24885]#4753

Merged
emmaoke-w merged 5 commits into
developfrom
test/WPB-24885-logged-device-removal-flow
Apr 23, 2026
Merged

test: centralize created-user teardown[WPB-24885]#4753
emmaoke-w merged 5 commits into
developfrom
test/WPB-24885-logged-device-removal-flow

Conversation

@emmaoke-w
Copy link
Copy Markdown
Contributor

@emmaoke-w emmaoke-w commented Apr 23, 2026

https://wearezeta.atlassian.net/browse/WPB-24885


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

PR Description

  • Centralized test teardown into a shared cleanupCreatedUsers(...) helper in BaseUiTest.

  • Made the shared teardown clearly separate three actions: remove backend clients/devices, delete teams, and optionally delete standalone personal users.

  • Updated ClientUserManager so created users are properly tracked in createdUsers when they are created through shared helper paths.

  • Registered created team owners, team members, and backend-created personal users into shared cleanup tracking.

  • Switched the team-based Android tests to use the shared cleanup path instead of repeating per-test manual delete logic.

  • Used deletePersonalUsers = true only where a standalone personal account is created and team deletion alone is not enough.

  • Fixed the Okta cleanup bug in SSO setup by reusing the same OktaApiClient instance during app creation and teardown instead of creating a throwaway client.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

image image

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w changed the title centralize created-user teardown test: centralize created-user teardown[WPB-24885] Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.51%. Comparing base (09b9b25) to head (a8ab866).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4753   +/-   ##
========================================
  Coverage    50.51%   50.51%           
========================================
  Files          603      603           
  Lines        20797    20797           
  Branches      3344     3344           
========================================
  Hits         10505    10505           
  Misses        9305     9305           
  Partials       987      987           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b9b25...a8ab866. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmaoke-w emmaoke-w marked this pull request as ready for review April 23, 2026 13:07
@emmaoke-w emmaoke-w requested a review from MohamadJaara April 23, 2026 14:34
Copy link
Copy Markdown
Collaborator

@CinnamonNinja CinnamonNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link
Copy Markdown

@emmaoke-w emmaoke-w removed the request for review from yamilmedina April 23, 2026 15:55
@emmaoke-w emmaoke-w enabled auto-merge April 23, 2026 15:56
@emmaoke-w emmaoke-w added this pull request to the merge queue Apr 23, 2026
Merged via the queue into develop with commit 873e2f0 Apr 23, 2026
15 of 16 checks passed
@emmaoke-w emmaoke-w deleted the test/WPB-24885-logged-device-removal-flow branch April 23, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants