Skip to content

feat: make bottom calling controls a draggable bottom sheet [WPB-1057]#4756

Merged
saleniuk merged 11 commits intodevelopfrom
feat/calling-controls-as-bottom-sheet
Apr 30, 2026
Merged

feat: make bottom calling controls a draggable bottom sheet [WPB-1057]#4756
saleniuk merged 11 commits intodevelopfrom
feat/calling-controls-as-bottom-sheet

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented Apr 24, 2026

https://wearezeta.atlassian.net/browse/WPB-1057


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Call screen needs to have a draggable bottom sheet with calling controls, where list of participants will be placed.

Solutions

OngoingCallScreen using BottomSheetScaffold back again. It got reduced and simplified some time ago, when implementing in-call reactions panel and in the meantime we implemented landscape mode with support for tablets and edge-to-edge, so some changes had to be made.

  • added BottomSheetScaffold and changed so that it works more like on designs and similarly to ModalBottomSheet with closing on back and tapping outside and scrim color
  • extracted WireDragHandle into a dedicated class and made it animated so that it can change state from arrow to line
  • BackHandlers taken out from the children and moved up in the hierarchy so that it doesn't interfere with the one implemented for the bottom sheet
  • CallingControls moved to the sheet content
  • sheet "peek height" calculated dynamically depending on the CallingControls height, to include security banner if visible for instance
  • created a way to preview OngoingCallScreen with SecurityClassificationBanner even if it uses its own scoped ViewModel by introducing PreviewSecurityClassificationBannerState

Testing

How to Test

Start or join a call and check the layout (currently dragging/opening bottom sheet is disabled until list of participants is implemented).

Attachments (Optional)

Screen_recording_20260423_150004.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from Garzas and sbakhtiarov April 27, 2026 07:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.80%. Comparing base (5d3578c) to head (8410ead).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4756   +/-   ##
========================================
  Coverage    50.80%   50.80%           
========================================
  Files          605      604    -1     
  Lines        20887    20886    -1     
  Branches      3370     3370           
========================================
  Hits         10612    10612           
+ Misses        9276     9275    -1     
  Partials       999      999           
Files with missing lines Coverage Δ
...m/wire/android/feature/sketch/DrawingToolPicker.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3578c...8410ead. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov
Copy link
Copy Markdown
Contributor

Is this UI also adapted for tablets?

@saleniuk
Copy link
Copy Markdown
Contributor Author

Is this UI also adapted for tablets?

Currently we follow the most recent designs for landscape and big screens, so the sheet takes the whole width (fortunately now it's already possible to set the max width):
image
but thank you very much for your comment, as it made me notice that the calling controls should have a max width so that they don't stretch to the full width on landscape, so I changed that. 🙇

@sonarqubecloud
Copy link
Copy Markdown

@saleniuk saleniuk requested a review from ohassine April 30, 2026 09:22
@saleniuk saleniuk added this pull request to the merge queue Apr 30, 2026
Merged via the queue into develop with commit 676f6f9 Apr 30, 2026
20 checks passed
@saleniuk saleniuk deleted the feat/calling-controls-as-bottom-sheet branch April 30, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants