fix: move message asset paths to conversation-scoped cache VM [WPB-25002]#4760
Merged
Conversation
MohamadJaara
approved these changes
Apr 24, 2026
4 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4760 +/- ##
========================================
Coverage 50.79% 50.80%
========================================
Files 604 605 +1
Lines 20847 20887 +40
Branches 3358 3370 +12
========================================
+ Hits 10590 10612 +22
- Misses 9265 9276 +11
- Partials 992 999 +7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
6748248 to
7ce9008
Compare
sbakhtiarov
approved these changes
Apr 27, 2026
| viewModel.resolveIfNeeded( | ||
| val messageId = message.header.messageId | ||
| val localAssetPath = conversationAssetPathsViewModel.localAssetPath(messageId) | ||
| LaunchedEffect(messageId, assetStatus) { |
Contributor
There was a problem hiding this comment.
Could we move these 'LaunchEffect' blocks into ViewModel? Like this:
override fun localAssetPath(conversationId: ConversationId, messageId: String, assetStatus: AssetTransferStatus?): String? = localAssetPaths[messageId].also { path ->
if (path == null && resolvingJobs[messageId]?.isActive != true) {
resolveIfNeeded(
conversationId = conversationId,
messageId = messageId,
transferStatus = assetStatus ?: AssetTransferStatus.NOT_DOWNLOADED,
downloadIfNeeded = true,
)
}
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-25002
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Causes (Optional)
nullpath.Solutions
messageId -> localPath) and updated image/video/asset rendering to use it.