Skip to content

fix: flaky unit test (WPB-8645)#4767

Merged
sbakhtiarov merged 5 commits into
developfrom
flaky-unit-test
Apr 29, 2026
Merged

fix: flaky unit test (WPB-8645)#4767
sbakhtiarov merged 5 commits into
developfrom
flaky-unit-test

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Apr 28, 2026

https://wearezeta.atlassian.net/browse/WPB-8645


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

dependabot Bot and others added 5 commits April 28, 2026 00:59
Bumps [app.cash.turbine:turbine](https://github.com/cashapp/turbine) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/cashapp/turbine/releases)
- [Changelog](https://github.com/cashapp/turbine/blob/trunk/CHANGELOG.md)
- [Commits](cashapp/turbine@1.2.0...1.2.1)

---
updated-dependencies:
- dependency-name: app.cash.turbine:turbine
  dependency-version: 1.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.79%. Comparing base (431b2cf) to head (7b02582).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...n/com/wire/android/util/GetMediaMetadataUseCase.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4767      +/-   ##
===========================================
- Coverage    50.81%   50.79%   -0.02%     
===========================================
  Files          603      604       +1     
  Lines        20844    20847       +3     
  Branches      3358     3358              
===========================================
- Hits         10592    10590       -2     
- Misses        9252     9265      +13     
+ Partials      1000      992       -8     
Files with missing lines Coverage Δ
...rsations/attachment/MessageAttachmentsViewModel.kt 45.71% <100.00%> (+0.39%) ⬆️
...n/com/wire/android/util/GetMediaMetadataUseCase.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431b2cf...7b02582. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Apr 29, 2026
Merged via the queue into develop with commit 67d21d4 Apr 29, 2026
18 checks passed
@sbakhtiarov sbakhtiarov deleted the flaky-unit-test branch April 29, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants