Skip to content

fix: do not show toast when trying to log in again [WPB-25221]#4778

Merged
MohamadJaara merged 4 commits into
developfrom
marco/remove-nomad-toast
May 4, 2026
Merged

fix: do not show toast when trying to log in again [WPB-25221]#4778
MohamadJaara merged 4 commits into
developfrom
marco/remove-nomad-toast

Conversation

@marcoconti83
Copy link
Copy Markdown
Member

@marcoconti83 marcoconti83 commented May 4, 2026

https://wearezeta.atlassian.net/browse/WPB-25221

What's new in this PR?

When starting a nomad profile login flow via intent, if the user was already logged in, the user would see a toast informing them that they can't log in again.

However, the customer using nomad profiles will always start the app via the intent. They should not see an error if they are already logged in with a nomad profile account.

@MohamadJaara MohamadJaara self-requested a review May 4, 2026 08:58
@MohamadJaara MohamadJaara changed the title Fix: do not show toast when trying to log in again fix: do not show toast when trying to log in again May 4, 2026
Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.05%. Comparing base (b57ac94) to head (83eb7d9).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4778      +/-   ##
===========================================
- Coverage    51.05%   51.05%   -0.01%     
===========================================
  Files          606      606              
  Lines        21043    21045       +2     
  Branches      3393     3394       +1     
===========================================
+ Hits         10743    10744       +1     
  Misses        9292     9292              
- Partials      1008     1009       +1     
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 75.19% <75.00%> (-0.14%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57ac94...83eb7d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara changed the title fix: do not show toast when trying to log in again fix: do not show toast when trying to log in again [WPB-25221] May 4, 2026
@MohamadJaara MohamadJaara merged commit b5d7586 into develop May 4, 2026
17 of 18 checks passed
@MohamadJaara MohamadJaara deleted the marco/remove-nomad-toast branch May 4, 2026 14:03
MohamadJaara added a commit that referenced this pull request May 4, 2026
Co-authored-by: Mohamad Jaara <9083456+MohamadJaara@users.noreply.github.com>
(cherry picked from commit b5d7586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants