Skip to content

fix: mapping for fdroid not found, builds without version code (WPB-8645)#4779

Merged
MohamadJaara merged 3 commits into
developfrom
fix/mappinfile-fdroid
May 5, 2026
Merged

fix: mapping for fdroid not found, builds without version code (WPB-8645)#4779
MohamadJaara merged 3 commits into
developfrom
fix/mappinfile-fdroid

Conversation

@yamilmedina
Copy link
Copy Markdown
Contributor

@yamilmedina yamilmedina commented May 4, 2026

https://wearezeta.atlassian.net/browse/WPB-8645


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Mapping file for fdroid build is not found

Causes (Optional)

Fdroid builds does not have version code in their name, so the parsing of the mapping file is not able to get the right path.

Solutions

Use find instead to find the mapping file, and check if the version code is defined for the build, use it, otherwise ignore it. This keeps retro compat with store builds and fdroid


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.05%. Comparing base (612635e) to head (f52b9f7).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4779   +/-   ##
========================================
  Coverage    51.05%   51.05%           
========================================
  Files          606      606           
  Lines        21045    21045           
  Branches      3394     3394           
========================================
  Hits         10744    10744           
  Misses        9292     9292           
  Partials      1009     1009           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612635e...f52b9f7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina requested a review from saleniuk May 4, 2026 16:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@MohamadJaara MohamadJaara added this pull request to the merge queue May 5, 2026
Merged via the queue into develop with commit 2f78b1b May 5, 2026
21 checks passed
@MohamadJaara MohamadJaara deleted the fix/mappinfile-fdroid branch May 5, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants