fix: mapping for fdroid not found, builds without version code (WPB-8645)#4779
Merged
Conversation
MohamadJaara
approved these changes
May 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4779 +/- ##
========================================
Coverage 51.05% 51.05%
========================================
Files 606 606
Lines 21045 21045
Branches 3394 3394
========================================
Hits 10744 10744
Misses 9292 9292
Partials 1009 1009 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
saleniuk
approved these changes
May 5, 2026
yamilmedina
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-8645
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Mapping file for fdroid build is not found
Causes (Optional)
Fdroid builds does not have version code in their name, so the parsing of the mapping file is not able to get the right path.
Solutions
Use find instead to find the mapping file, and check if the version code is defined for the build, use it, otherwise ignore it. This keeps retro compat with store builds and fdroid
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.