Skip to content

fix: video asset preview and size (WPB-24809)#4803

Merged
sbakhtiarov merged 5 commits into
developfrom
fix/video-asset
May 11, 2026
Merged

fix: video asset preview and size (WPB-24809)#4803
sbakhtiarov merged 5 commits into
developfrom
fix/video-asset

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 8, 2026

https://wearezeta.atlassian.net/browse/WPB-24809

https://wearezeta.atlassian.net/browse/WPB-24809

What's new in this PR?

Issues

Issues with showing video preview and duration:

  1. Duration is not showing for video previews
  2. Preview and message size do not match the video aspect ratio

Causes (Optional)

  1. Missing mapping for the video metadata.
  2. Video metadata not read when sending video.
  3. Local path for uploaded video file not resolved correctly

Solutions

Added missing mappings (kalium)
Read video file metadata before sending
Fixed local path resolution for Uploaded video assets

Before:
https://github.com/user-attachments/assets/b9094869-0eb6-4e6d-9aca-3410afa107c4

After:
https://github.com/user-attachments/assets/27b6925a-ed60-4c0e-bd16-1392a611e7f9

@sbakhtiarov sbakhtiarov enabled auto-merge May 11, 2026 08:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.10%. Comparing base (ee482be) to head (4d902ed).

Files with missing lines Patch % Lines
.../conversations/sendmessage/SendMessageViewModel.kt 51.72% 10 Missing and 4 partials ⚠️
...s/messages/item/ConversationAssetPathsViewModel.kt 80.00% 1 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (62.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4803      +/-   ##
===========================================
- Coverage    51.12%   51.10%   -0.02%     
===========================================
  Files          610      610              
  Lines        21093    21089       -4     
  Branches      3399     3392       -7     
===========================================
- Hits         10783    10778       -5     
- Misses        9295     9299       +4     
+ Partials      1015     1012       -3     
Files with missing lines Coverage Δ
...ersations/messages/item/AssetLocalPathViewModel.kt 70.83% <100.00%> (-1.59%) ⬇️
...ersations/model/messagetypes/video/VideoMessage.kt 0.00% <ø> (ø)
...s/messages/item/ConversationAssetPathsViewModel.kt 74.19% <80.00%> (+14.73%) ⬆️
.../conversations/sendmessage/SendMessageViewModel.kt 76.98% <51.72%> (-2.87%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee482be...4d902ed. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@sbakhtiarov sbakhtiarov added this pull request to the merge queue May 11, 2026
Merged via the queue into develop with commit 9db09d7 May 11, 2026
18 of 19 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/video-asset branch May 11, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants