Skip to content

fix: changes to the call participants list to match all the other requirements [WPB-1057]#4823

Merged
saleniuk merged 1 commit into
developfrom
fix/call-participant-list-additional-fixes
May 13, 2026
Merged

fix: changes to the call participants list to match all the other requirements [WPB-1057]#4823
saleniuk merged 1 commit into
developfrom
fix/call-participant-list-additional-fixes

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented May 13, 2026

https://wearezeta.atlassian.net/browse/WPB-1057


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • there is no separate state for the connecting user
  • call participants are not sorted alphabetically
  • there is no indication next to your name
  • accessibility missing for the drag handle

Solutions

  • for the connecting user, created a separate state with disabled colors and "connecting" label
  • added alphabetical order for the participants list
  • added "(You)" suffix to your name, just like on the conversation details participants list
  • added content description for the drag handle, now it says "Collapsed list of participants, double tap to expand"

Testing

How to Test

Start/join a call, enable talkback, focus on the drag handle. Open the participants list while someone is connecting.

Attachments (Optional)

image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

@saleniuk saleniuk added this pull request to the merge queue May 13, 2026
Merged via the queue into develop with commit 3afba09 May 13, 2026
19 of 20 checks passed
@saleniuk saleniuk deleted the fix/call-participant-list-additional-fixes branch May 13, 2026 12:17
saleniuk added a commit that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants