Skip to content

fix: conversation list reloading and scrolling when navigating back [WPB-25642]#4845

Merged
MohamadJaara merged 1 commit into
developfrom
fix/conv-list-reloading-when-nav-back
May 20, 2026
Merged

fix: conversation list reloading and scrolling when navigating back [WPB-25642]#4845
MohamadJaara merged 1 commit into
developfrom
fix/conv-list-reloading-when-nav-back

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented May 20, 2026

https://wearezeta.atlassian.net/browse/WPB-25642


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Conversation list is reloading each time user navigates back from the conversation.
When the list is first scrolled before navigating to conversation, then it’s scrolled back to top when going back.
Search top bar is showing and hiding instantly when navigating back to the conversation list if it was scrolled before.

Solutions

  • use shareIn for the flow - LazyPagingItems checks for the SharedFlow to get cachedPagingData
  • separate LazyListState so that the loading screen doesn't use the same one as the regular list and doesn't modify its values
  • adjust initial values for the draggable expandable top bar
  • save and restore isSearchVisible parameter for the search top bar

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • open the app
  • scroll the conversation list
  • open some conversation
  • receive a message
  • navigate back
  • the list should not reload and be at the same position as it was before opening the conversation

Attachments (Optional)

Before After
Screen_recording_20260513_154219.1.mp4
Screen_recording_20260519_195228.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.21%. Comparing base (361c7df) to head (912119e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4845   +/-   ##
========================================
  Coverage    51.21%   51.21%           
========================================
  Files          611      611           
  Lines        21159    21160    +1     
  Branches      3403     3403           
========================================
+ Hits         10837    10838    +1     
  Misses        9307     9307           
  Partials      1015     1015           
Files with missing lines Coverage Δ
...ome/conversationslist/ConversationListViewModel.kt 35.26% <100.00%> (+0.34%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361c7df...912119e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara added this pull request to the merge queue May 20, 2026
Merged via the queue into develop with commit 33ddcd8 May 20, 2026
18 checks passed
@MohamadJaara MohamadJaara deleted the fix/conv-list-reloading-when-nav-back branch May 20, 2026 08:54
MohamadJaara pushed a commit that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants